Re: [RFA 3/5] Use new and delete for struct infcall_control_state

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2018-07-11 11:36, Simon Marchi wrote:
> On 2018-07-11 10:15, Tom Tromey wrote:
>> diff --git a/gdb/infrun.c b/gdb/infrun.c
>> index 1157b266b1a..3bc8dc03830 100644
>> --- a/gdb/infrun.c
>> +++ b/gdb/infrun.c
>> @@ -8927,15 +8927,15 @@ get_infcall_suspend_state_regcache (struct
>> infcall_suspend_state *inf_state)
>> 
>>  struct infcall_control_state
>>  {
>> -  struct thread_control_state thread_control;
>> -  struct inferior_control_state inferior_control;
>> +  struct thread_control_state thread_control {};
>> +  struct inferior_control_state inferior_control {};
> 
> Same here, you could remove the {} here and make the
> thread/inferior_control_state objects initialize themselves.
> thread_info::control and thread_info::suspend then won't need to be
> explicitly initialized.

You probably got it anyway, but the last sentence should have said 
inferior::control and thread_info::control.

Simon