From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76692 invoked by alias); 11 Jul 2018 15:42:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76674 invoked by uid 89); 11 Jul 2018 15:42:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Jul 2018 15:42:33 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w6BFgRRc027397 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 11 Jul 2018 11:42:31 -0400 Received: by simark.ca (Postfix, from userid 112) id 070C91E76F; Wed, 11 Jul 2018 11:42:27 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 966C61E093; Wed, 11 Jul 2018 11:42:26 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 11 Jul 2018 15:42:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 3/5] Use new and delete for struct infcall_control_state In-Reply-To: References: <20180711141552.10136-1-tom@tromey.com> <20180711141552.10136-4-tom@tromey.com> Message-ID: <74de67676575c8f8f951a78826bc39e3@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00314.txt.bz2 On 2018-07-11 11:36, Simon Marchi wrote: > On 2018-07-11 10:15, Tom Tromey wrote: >> diff --git a/gdb/infrun.c b/gdb/infrun.c >> index 1157b266b1a..3bc8dc03830 100644 >> --- a/gdb/infrun.c >> +++ b/gdb/infrun.c >> @@ -8927,15 +8927,15 @@ get_infcall_suspend_state_regcache (struct >> infcall_suspend_state *inf_state) >> >> struct infcall_control_state >> { >> - struct thread_control_state thread_control; >> - struct inferior_control_state inferior_control; >> + struct thread_control_state thread_control {}; >> + struct inferior_control_state inferior_control {}; > > Same here, you could remove the {} here and make the > thread/inferior_control_state objects initialize themselves. > thread_info::control and thread_info::suspend then won't need to be > explicitly initialized. You probably got it anyway, but the last sentence should have said inferior::control and thread_info::control. Simon