From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>, Yao Qi <qiyaoltc@gmail.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] PR python/18565 - make Frame.function work for inline frames
Date: Wed, 03 Aug 2016 17:57:00 -0000 [thread overview]
Message-ID: <74af1e6e-a557-af32-424a-e70b0384cbf9@redhat.com> (raw)
In-Reply-To: <87eg65lwb2.fsf@tromey.com>
On 08/03/2016 04:13 PM, Tom Tromey wrote:
>>>>>> "Yao" == Yao Qi <qiyaoltc@gmail.com> writes:
>
>>> In any case, IMO this would be the subject of a separate patch.
>
> Yao> This is the prerequisite of Tom's patch, no? It guarantees that *FUNNAME
> Yao> is not allocated if exception is thrown, otherwise *FUNAME is allocated.
> Yao> Tom's patch relies on this behaviour.
>
> Yao> I am OK with Tom's original patch, but we need to fix find_frame_funname
> Yao> first.
>
> Here's a patch. Please review.
>
LGTM.
> I'd like to check this and the other into the 7.12 branch as well.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-08-03 17:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 16:11 Tom Tromey
[not found] ` <86ziqfq6sz.fsf@gmail.com>
2016-06-22 18:43 ` Tom Tromey
2016-07-25 10:23 ` Yao Qi
2016-07-25 11:04 ` Pedro Alves
2016-07-25 15:01 ` Tom Tromey
2016-07-26 11:14 ` Pedro Alves
2016-07-26 13:18 ` Tom Tromey
2016-07-26 14:33 ` Pedro Alves
2016-08-03 8:15 ` Yao Qi
2016-08-03 15:14 ` Tom Tromey
2016-08-03 17:57 ` Pedro Alves [this message]
2016-08-03 8:07 ` Yao Qi
2016-08-03 11:35 ` Pedro Alves
2016-08-03 13:15 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74af1e6e-a557-af32-424a-e70b0384cbf9@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox