From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79858 invoked by alias); 3 Aug 2016 17:57:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76634 invoked by uid 89); 3 Aug 2016 17:57:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 03 Aug 2016 17:57:47 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7AAB161E47; Wed, 3 Aug 2016 17:57:46 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u73HvjOi014494; Wed, 3 Aug 2016 13:57:45 -0400 Subject: Re: [RFA] PR python/18565 - make Frame.function work for inline frames To: Tom Tromey , Yao Qi References: <1466439050-11330-1-git-send-email-tom@tromey.com> <86ziqfq6sz.fsf@gmail.com> <8737o5kqtv.fsf@tromey.com> <87bn1lu5h9.fsf@tromey.com> <5ab877f8-9e39-6e02-2ece-46fcbcdacc0a@redhat.com> <87eg65lwb2.fsf@tromey.com> Cc: "gdb-patches@sourceware.org" From: Pedro Alves Message-ID: <74af1e6e-a557-af32-424a-e70b0384cbf9@redhat.com> Date: Wed, 03 Aug 2016 17:57:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <87eg65lwb2.fsf@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-08/txt/msg00077.txt.bz2 On 08/03/2016 04:13 PM, Tom Tromey wrote: >>>>>> "Yao" == Yao Qi writes: > >>> In any case, IMO this would be the subject of a separate patch. > > Yao> This is the prerequisite of Tom's patch, no? It guarantees that *FUNNAME > Yao> is not allocated if exception is thrown, otherwise *FUNAME is allocated. > Yao> Tom's patch relies on this behaviour. > > Yao> I am OK with Tom's original patch, but we need to fix find_frame_funname > Yao> first. > > Here's a patch. Please review. > LGTM. > I'd like to check this and the other into the 7.12 branch as well. Thanks, Pedro Alves