Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Eli Zaretskii" <eliz@is.elta.co.il>
To: ac131313@cygnus.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfc/rfa:doc] INTEGER_TO_ADDRESS; Was: INTEGER_TO_ADDRESS(), thoughts?
Date: Tue, 02 Oct 2001 00:11:00 -0000	[thread overview]
Message-ID: <7458-Tue02Oct2001091222+0300-eliz@is.elta.co.il> (raw)
In-Reply-To: <3BB8CA42.8030209@cygnus.com>

> Date: Mon, 01 Oct 2001 15:55:46 -0400
> From: Andrew Cagney <ac131313@cygnus.com>
> 
> Attached is a revised patch.  I've also added a pragmatics section to 
> the relevant documentation.

Approved, with these minor corrections:

> + @item INTEGER_TO_ADDRESS (@var{type}, @var{buf})
> + @findex INTEGER_TO_ADDRESS

I suggest "@cindex converting integers to addresses" here.

> + compiler does.  When the user copies a well defined expression from
> + their source code and hand it to a @code{print} command, they should get
> + the same value as would have been computed by the target program.

Since most of this sentence is in plural, I think it should start with
"When the users copy".

> + needs to be justified carefully.  In other words, GDB doesn't really
> + have the freedom to do these conversions in clever and useful ways. It
> + has, however, been pointed out that users aren't complaining about how
> + GDB casts integers to pointers; they are complaining that they can't

"GDB" should be "@value{GDBN}".

> + Adding an architecture method like @code{INTEGER_TO_ADDRESS} certainly
> + makes it possible for GDB to "get it right" in all circumstances.}

Texinfo sources should use `` and '' instead of " for quoting.

There's also at least one place with a single space between two
sentences.


  reply	other threads:[~2001-10-02  0:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <3BA7F150.9060302@cygnus.com>
     [not found] ` <np1ykw8bny.fsf@zwingli.cygnus.com>
2001-09-25 14:25   ` Andrew Cagney
2001-10-01 12:56     ` Andrew Cagney
2001-10-02  0:11       ` Eli Zaretskii [this message]
2001-10-03 13:29         ` Andrew Cagney
2001-10-03 23:10           ` Eli Zaretskii
2001-10-04 14:40             ` Andrew Cagney
2001-10-10 14:59               ` Andrew Cagney
2001-10-10 15:14             ` Martin M. Hunt
2001-10-10 17:05               ` Andrew Cagney
2001-10-10 17:59                 ` Frank Ch. Eigler
2001-10-15 11:32                 ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7458-Tue02Oct2001091222+0300-eliz@is.elta.co.il \
    --to=eliz@is.elta.co.il \
    --cc=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox