From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <palves@redhat.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 3/4] Create private_thread_info hierarchy
Date: Thu, 23 Nov 2017 16:56:00 -0000 [thread overview]
Message-ID: <73d948bf3efc9c51e9f0e52cb00950e1@polymtl.ca> (raw)
In-Reply-To: <6702102011e4d0ca966282ad8134a127@polymtl.ca>
>>> private:
>>> - thread_info *m_thread;
>>> + /* Use the "class" keyword here, because of a class with a
>>> "thread_info"
>>> + function in the Darwin API. */
>>> + class thread_info *m_thread;
>>
>> This comment sounds incorrect. A a "thread_info" function/method
>> inside some class couldn't possibly interfere, right? The issue is
>> that there's a _free-function_ called thread_info, right?
>
> Err yeah, the "class with a" part should not be there:
>
> + /* Use the "class" keyword here, because of a "thread_info"
> + function in the Darwin API. */
Ah actually I meant "because of a clash", I was one letter away.
Simon
prev parent reply other threads:[~2017-11-23 16:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 16:41 [PATCH 0/4] Poison XNEW and friends for non-POD types Simon Marchi
2017-11-22 16:41 ` [PATCH 1/4] Create private_inferior class hierarchy Simon Marchi
2017-11-22 22:20 ` Joel Brobecker
2017-11-24 15:46 ` Simon Marchi
2017-11-24 21:31 ` Joel Brobecker
2017-11-23 14:09 ` Pedro Alves
2017-11-23 16:17 ` Simon Marchi
2017-11-22 16:42 ` [PATCH 4/4] Poison XNEW and friends for types that should use new/delete Simon Marchi
2017-11-23 15:02 ` Pedro Alves
2017-11-23 17:27 ` Simon Marchi
2017-11-23 17:31 ` Pedro Alves
2017-11-22 16:42 ` [PATCH 2/4] remote: C++ify thread_item and threads_listing_context Simon Marchi
2017-11-23 14:22 ` Pedro Alves
2017-11-23 16:48 ` Simon Marchi
2017-11-23 16:52 ` Pedro Alves
2017-11-22 16:42 ` [PATCH 3/4] Create private_thread_info hierarchy Simon Marchi
2017-11-23 14:41 ` Pedro Alves
2017-11-23 16:54 ` Simon Marchi
2017-11-23 16:56 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73d948bf3efc9c51e9f0e52cb00950e1@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox