From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36716 invoked by alias); 23 Nov 2017 16:56:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36707 invoked by uid 89); 23 Nov 2017 16:56:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=letter X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Nov 2017 16:56:09 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id vANGu2b5006486 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 23 Nov 2017 11:56:07 -0500 Received: by simark.ca (Postfix, from userid 112) id 6B2E61E586; Thu, 23 Nov 2017 11:56:02 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id BC10D1E030; Thu, 23 Nov 2017 11:56:01 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 23 Nov 2017 16:56:00 -0000 From: Simon Marchi To: Pedro Alves Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 3/4] Create private_thread_info hierarchy In-Reply-To: <6702102011e4d0ca966282ad8134a127@polymtl.ca> References: <1511368867-19365-1-git-send-email-simon.marchi@ericsson.com> <1511368867-19365-4-git-send-email-simon.marchi@ericsson.com> <845f4008-78ed-f188-0506-c67f9e20f531@redhat.com> <6702102011e4d0ca966282ad8134a127@polymtl.ca> Message-ID: <73d948bf3efc9c51e9f0e52cb00950e1@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.2 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 23 Nov 2017 16:56:02 +0000 X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00563.txt.bz2 >>> private: >>> - thread_info *m_thread; >>> + /* Use the "class" keyword here, because of a class with a >>> "thread_info" >>> + function in the Darwin API. */ >>> + class thread_info *m_thread; >> >> This comment sounds incorrect. A a "thread_info" function/method >> inside some class couldn't possibly interfere, right? The issue is >> that there's a _free-function_ called thread_info, right? > > Err yeah, the "class with a" part should not be there: > > + /* Use the "class" keyword here, because of a "thread_info" > + function in the Darwin API. */ Ah actually I meant "because of a clash", I was one letter away. Simon