From: Simon Marchi <simon.marchi@polymtl.ca>
To: Jan Vrany <jan.vrany@fit.cvut.cz>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] MI: Fix printing of frame architecture with Python frame filters enabled
Date: Mon, 27 Aug 2018 21:15:00 -0000 [thread overview]
Message-ID: <7326f9d9b91d7eeecd867763af5c500a@polymtl.ca> (raw)
In-Reply-To: <20180827205244.28098-1-jan.vrany@fit.cvut.cz>
On 2018-08-27 16:52, Jan Vrany wrote:
> Commit 6d52907e226a (MI: Print frame architecture when printing frames
> on an MI channel) added frame's architecture to MI frame output.
> However
> the frame architecture was not correctly printed in the output of
> "-stack-list-frames" with frame filters enabled (via
> "-enable-frame-filters").
> This was because with frame filters enabled, the actual frame printing
> is
> done in "py_print_frame" rather than "print_frame". This issue is now
> fixed.
>
> gdb/Changelog:
> 2018-08-27 Jan Vrany <jan.vrany@fit.cvut.cz>
>
> * python/py-framefilter.c (py_print_frame): Print frame architecture
> when printing on an MI output.
>
> gdb/testsuite/Changelog:
> 2018-08-27 Jan Vrany <jan.vrany@fit.cvut.cz>
>
> * gdb.python/py-framefilter-mi.exp: Update regexp to
> check for "arch" field in frame output.
Ah, in my reply to v1 I really meant "you can push with that typo
fixed", but forgot you don't have a sourceware account (yet!). I would
not have made you send a v2 just for that if I had remembered, I would
have fixed it and pushed myself. Anyway, I pushed it now, thanks!
Simon
prev parent reply other threads:[~2018-08-27 21:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 20:53 Jan Vrany
2018-08-27 21:15 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7326f9d9b91d7eeecd867763af5c500a@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=jan.vrany@fit.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox