From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85758 invoked by alias); 27 Aug 2018 21:15:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85584 invoked by uid 89); 27 Aug 2018 21:15:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=remembered X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 27 Aug 2018 21:15:29 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w7RLFMqE016230 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 27 Aug 2018 17:15:27 -0400 Received: by simark.ca (Postfix, from userid 112) id 8AB971EB4C; Mon, 27 Aug 2018 17:15:22 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id CE6191E52D; Mon, 27 Aug 2018 17:15:21 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 27 Aug 2018 21:15:00 -0000 From: Simon Marchi To: Jan Vrany Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] MI: Fix printing of frame architecture with Python frame filters enabled In-Reply-To: <20180827205244.28098-1-jan.vrany@fit.cvut.cz> References: <20180827205244.28098-1-jan.vrany@fit.cvut.cz> Message-ID: <7326f9d9b91d7eeecd867763af5c500a@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00673.txt.bz2 On 2018-08-27 16:52, Jan Vrany wrote: > Commit 6d52907e226a (MI: Print frame architecture when printing frames > on an MI channel) added frame's architecture to MI frame output. > However > the frame architecture was not correctly printed in the output of > "-stack-list-frames" with frame filters enabled (via > "-enable-frame-filters"). > This was because with frame filters enabled, the actual frame printing > is > done in "py_print_frame" rather than "print_frame". This issue is now > fixed. > > gdb/Changelog: > 2018-08-27 Jan Vrany > > * python/py-framefilter.c (py_print_frame): Print frame architecture > when printing on an MI output. > > gdb/testsuite/Changelog: > 2018-08-27 Jan Vrany > > * gdb.python/py-framefilter-mi.exp: Update regexp to > check for "arch" field in frame output. Ah, in my reply to v1 I really meant "you can push with that typo fixed", but forgot you don't have a sourceware account (yet!). I would not have made you send a v2 just for that if I had remembered, I would have fixed it and pushed myself. Anyway, I pushed it now, thanks! Simon