From: Pedro Alves <pedro@palves.net>
To: Hannes Domani <ssbssa@yahoo.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix heap-use-after-free in index-cached with --disable-threading
Date: Fri, 10 May 2024 20:16:41 +0100 [thread overview]
Message-ID: <724b9a77-ca0b-4014-a19d-c187580400e2@palves.net> (raw)
In-Reply-To: <20240504110942.922-1-ssbssa@yahoo.de>
On 2024-05-04 12:09, Hannes Domani wrote:
> --- a/gdb/dwarf2/cooked-index.c
> +++ b/gdb/dwarf2/cooked-index.c
> @@ -513,7 +513,7 @@ cooked_index_worker::wait (cooked_state desired_state, bool allow_quit)
> #else
> /* Without threads, all the work is done immediately on the main
> thread, and there is never anything to wait for. */
> - done = true;
> + done = desired_state == cooked_state::CACHE_DONE;
I know nothing about this code, but I wondered if the "never" above in the comment
should say something else. It matched the old code that just assigned to true, but
now it's conditional, which doesn't read like "never".
next prev parent reply other threads:[~2024-05-10 19:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240504110942.922-1-ssbssa.ref@yahoo.de>
2024-05-04 11:09 ` Hannes Domani
2024-05-04 15:45 ` Tom Tromey
2024-05-04 16:28 ` Hannes Domani
2024-05-04 16:56 ` Hannes Domani
2024-05-10 5:59 ` Bernd Edlinger
2024-05-10 13:50 ` Hannes Domani
2024-05-10 18:03 ` Tom Tromey
2024-05-11 6:44 ` Bernd Edlinger
2024-05-10 19:16 ` Pedro Alves [this message]
2024-05-11 10:47 ` Hannes Domani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=724b9a77-ca0b-4014-a19d-c187580400e2@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=ssbssa@yahoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox