From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ZMLOC7lyPmbHYw0AWB0awg (envelope-from ) for ; Fri, 10 May 2024 15:17:13 -0400 Received: by simark.ca (Postfix, from userid 112) id 1D2FD1E0C1; Fri, 10 May 2024 15:17:13 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 07E411E092 for ; Fri, 10 May 2024 15:17:11 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A7F0B3870846 for ; Fri, 10 May 2024 19:17:10 +0000 (GMT) Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by sourceware.org (Postfix) with ESMTPS id 6D80F386F804 for ; Fri, 10 May 2024 19:16:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6D80F386F804 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6D80F386F804 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.208.179 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715368613; cv=none; b=Vf3vbQe8fX/7F7f+5tGMYHp2cUuDGkDfzkYR+sKNBJZh9IOMtwB20qBu7JP5XNwjS6d+Q9ZL1K3M3ZYQS4D0l0+jViwpalY2hsdMAedUUIZvE92hv/7s+mRDbADOZcSCDlr81EyDjd1S/YJa0wibOpG2jVvplq2/7vbSJ3kupVg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715368613; c=relaxed/simple; bh=zKONr/gMadF7h1E1ZGkkdz9eR54dIDxTjwkmBVS5Ebs=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=ut+2QU0+kGnfDRQ16QDvDUZu5r4PMvtbfazemX7lPLFldT98XraSsKHlftgpv3ra9/4uEB/ATB9AtZ6H3d7qQbNqJwmbPz+4KvDpOJucnMkw6VsI21qjJpJdaHK4hAVGUjXjILba9RrV0Jxq8RRqK/d1pZWW6WpFtgTnAwgvLI8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2dcc8d10d39so27352741fa.3 for ; Fri, 10 May 2024 12:16:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715368610; x=1715973410; h=content-transfer-encoding:in-reply-to:content-language:from :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rOBgyEdKdQJnagkBw5AAJZAtlctB6BIAc1EZAfYxebM=; b=Wu4OJBXGNfvV2rjE+jkGZiSYV0fTxUcwyaC9L2cwmalFZcQIGsi3uCLrDZiE/LIDIJ lLZX4D/cFL3FDAvWg/EmRiN5ZYSxmPSQgjug6TycxwQTWkOferkZBg34kUjzqPZZajAE EUPjLVQtUzW8qNef4kQ6OIJEokKwo+3vcPIYpZqML5hkvkdZ/Q+Hf6Mq+d8xjBBmBjwp 9bj0EVHWVbykFKLhy1Nt/mDFQ5OP3RKiNs1vaYqCThzRJ3JhgpxRm/cEyrQyJaH/sLpA ruHR5dDUmpvSNXeMqvmYTBsP4VSvv2qKQqVvDGmtq7bKOlbGPpeLCFzM3Did2R/foALS mGcQ== X-Forwarded-Encrypted: i=1; AJvYcCU579ek8JBZQdJ4oipGYEJzuyv8sbV15936aB6SmUsrr4v4YpN0RfFLd8V/YiYu0fg/XOlQJJTYaGJRayR/VvTltSGKYqLgACGNQw== X-Gm-Message-State: AOJu0YxYitdDQfqT62HyY5xUHjtD7XaQu9ia2MCjrUnbOSn5ALcHtQ7I uPD5QA2yH/Hm0kxY1EKGU9v19gnUvqSrYBh+gCXEERx6XyNT9PAd X-Google-Smtp-Source: AGHT+IG1iB/rFLFSbAKPQrB5/K5RLwparheKGxFtm4s/wAgCULMPgBMiZYwrbtBA+ic7idGazngqQQ== X-Received: by 2002:a2e:95cc:0:b0:2e5:61f8:db58 with SMTP id 38308e7fff4ca-2e561f8e06emr4650601fa.11.1715368609739; Fri, 10 May 2024 12:16:49 -0700 (PDT) Received: from ?IPV6:2001:8a0:f908:4900:6534:b101:e988:663d? ([2001:8a0:f908:4900:6534:b101:e988:663d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-41fccbe8f8asm73473865e9.10.2024.05.10.12.16.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 May 2024 12:16:49 -0700 (PDT) Message-ID: <724b9a77-ca0b-4014-a19d-c187580400e2@palves.net> Date: Fri, 10 May 2024 20:16:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fix heap-use-after-free in index-cached with --disable-threading To: Hannes Domani , gdb-patches@sourceware.org References: <20240504110942.922-1-ssbssa.ref@yahoo.de> <20240504110942.922-1-ssbssa@yahoo.de> From: Pedro Alves Content-Language: en-US In-Reply-To: <20240504110942.922-1-ssbssa@yahoo.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 2024-05-04 12:09, Hannes Domani wrote: > --- a/gdb/dwarf2/cooked-index.c > +++ b/gdb/dwarf2/cooked-index.c > @@ -513,7 +513,7 @@ cooked_index_worker::wait (cooked_state desired_state, bool allow_quit) > #else > /* Without threads, all the work is done immediately on the main > thread, and there is never anything to wait for. */ > - done = true; > + done = desired_state == cooked_state::CACHE_DONE; I know nothing about this code, but I wondered if the "never" above in the comment should say something else. It matched the old code that just assigned to true, but now it's conditional, which doesn't read like "never".