Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Hannes Domani via gdb-patches" <gdb-patches@sourceware.org>
To: Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: Propose we release GDB 9.1 next weekend (Feb 01-02)
Date: Tue, 28 Jan 2020 17:06:00 -0000	[thread overview]
Message-ID: <720913399.742914.1580230424544@mail.yahoo.com> (raw)
In-Reply-To: <20200126114033.GA20733@adacore.com>

 Am Sonntag, 26. Januar 2020, 12:40:48 MEZ hat Joel Brobecker <brobecker@adacore.com> Folgendes geschrieben:

> Hello everyone,
>
> As far as I can tell, we still have a couple of issues open, with
> unfortunately no progress that I can tell for the past week or so.
> At this point, the GDB 9.1 release has really been a long time coming,
> we really should try to get it out the door soon. Here are the
> remaining known issue, with my comments on how I propose we proceed:

I just noticed that gdbserver is a bit broken for x86_64-mingw (and I think
it always was).

Reason for it is this part in gdbserver/server.c:

    document += string_printf
      ("  <library name=\"%s\"><segment address=\"0x%lx\"/></library>\n",
       dll.name.c_str (), (long) dll.base_addr);

(long) is always 32bit on Windows, so the upper bits are cut off.

Fix seems simple:

     document += string_printf
-      ("  <library name=\"%s\"><segment address=\"0x%lx\"/></library>\n",
-       dll.name.c_str (), (long) dll.base_addr);
+      ("  <library name=\"%s\"><segment address=\"0x%s\"/></library>\n",
+       dll.name.c_str (), paddress (dll.base_addr));

I just tested it and this improves the debugging experience a lot.

But I guess this is probably too late for the release.


Regards
Hannes Domani


  parent reply	other threads:[~2020-01-28 16:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-26 15:41 Joel Brobecker
2020-01-26 16:07 ` Eli Zaretskii
2020-01-28 16:43 ` Nick Alcock
2020-01-28 17:06 ` Hannes Domani via gdb-patches [this message]
     [not found]   ` <ee83b6c0-8e18-eb1e-18c8-f9df79b547d7@simark.ca>
2020-01-28 17:37     ` Hannes Domani via gdb-patches
2020-02-01  3:20 ` Jonah Graham
2020-02-01  8:00   ` Simon Marchi
2020-02-01 12:17     ` Joel Brobecker
2020-02-01 12:58       ` Jonah Graham
2020-02-01 13:06         ` Joel Brobecker
2020-02-05 10:08           ` Tom Tromey
2020-02-01 15:45         ` Simon Marchi
2020-02-01 15:37       ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=720913399.742914.1580230424544@mail.yahoo.com \
    --to=gdb-patches@sourceware.org \
    --cc=ssbssa@yahoo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox