Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Jonah Graham <jonah@kichwacoders.com>
Cc: Simon Marchi <simark@simark.ca>, Tom Tromey <tom@tromey.com>,
	gdb-patches@sourceware.org, Pedro Alves <palves@redhat.com>,
	Iain Buclaw <ibuclaw@gdcproject.org>,
	Nick Alcock <nick.alcock@oracle.com>,
	Eli Zaretskii <eliz@gnu.org>
Subject: Re: Propose we release GDB 9.1 next weekend (Feb 01-02)
Date: Sat, 01 Feb 2020 13:06:00 -0000	[thread overview]
Message-ID: <20200201130634.GA3103@adacore.com> (raw)
In-Reply-To: <CAPmGMvhOazCaTg66qQBqyZUEbiP0bo_ummMPRth0HvXU+AfWng@mail.gmail.com>

> > I haven't reviewed the patch super carefully, but I like the idea!
> >
> > For the release, it's indeed a bit on the fence. Given the nature of
> > the patch, With a bit of careful review, we should be able to convince
> > ourselves that this patch is sufficiently safe, particularly for a .1.
> > On the other hand, I think the patch that triggered the regression is
> > a fairly minor enhancement (name of the file printed by annotations).
> > So perhaps the best way forward is to revert the triggering patch
> > from the gdb-9-branch.
> >
> > I've added Tom to way in on this...
> 
> Tom If you decide to revert (which would be my preference) I will
> happily work with you to get this back in. I previously wrote a
> testcase for the simple case that did already get fixed, I can work on
> a testcase for the new case too for the suite if it helps.
> https://sourceware.org/ml/gdb-patches/2019-08/msg00421.html

FWIW, in terms of reverting, I was only thinking of reverting
in the gdb-9-branch. It's possible we might decide to revert
in master as well, but, at the moment, it's looking like we have
a decent chance of fixing the issue in master withing a reasonable
time frame. So I'm not advocating for a revert in master just yet.
Open to people's thoughts, though, as always!

-- 
Joel


  reply	other threads:[~2020-02-01 13:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-26 15:41 Joel Brobecker
2020-01-26 16:07 ` Eli Zaretskii
2020-01-28 16:43 ` Nick Alcock
2020-01-28 17:06 ` Hannes Domani via gdb-patches
     [not found]   ` <ee83b6c0-8e18-eb1e-18c8-f9df79b547d7@simark.ca>
2020-01-28 17:37     ` Hannes Domani via gdb-patches
2020-02-01  3:20 ` Jonah Graham
2020-02-01  8:00   ` Simon Marchi
2020-02-01 12:17     ` Joel Brobecker
2020-02-01 12:58       ` Jonah Graham
2020-02-01 13:06         ` Joel Brobecker [this message]
2020-02-05 10:08           ` Tom Tromey
2020-02-01 15:45         ` Simon Marchi
2020-02-01 15:37       ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200201130634.GA3103@adacore.com \
    --to=brobecker@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=ibuclaw@gdcproject.org \
    --cc=jonah@kichwacoders.com \
    --cc=nick.alcock@oracle.com \
    --cc=palves@redhat.com \
    --cc=simark@simark.ca \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox