From: Keith Seitz <keiths@redhat.com>
To: Daniel Knezevic <daniel.knezevic@htecgroup.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH v3] gdb/symtab.c Fix completion of template class members
Date: Mon, 27 Apr 2026 08:28:30 -0700 [thread overview]
Message-ID: <72021792-2f5a-47a4-a3aa-8141ae2e2bee@redhat.com> (raw)
In-Reply-To: <20260420120310.64156-1-daniel.knezevic@htecgroup.com>
On 4/20/26 5:03 AM, Daniel Knezevic wrote:
> Hi,
>
> Is there anything I need to change for this patch?
>
> I have updated the patch based on Keith's comments that you can find bellow:
You've addressed all my comments, so this LGTM. Just to reiterate:
Reviewed-By: Keith Seitz <keiths@redhat.com>
Thank you for the patch and your patience.
Keith
prev parent reply other threads:[~2026-04-27 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 10:36 Daniel Knezevic
2026-03-03 18:19 ` Keith Seitz
2026-04-20 12:03 ` Daniel Knezevic
2026-04-27 15:28 ` Keith Seitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72021792-2f5a-47a4-a3aa-8141ae2e2bee@redhat.com \
--to=keiths@redhat.com \
--cc=daniel.knezevic@htecgroup.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox