From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id n7VGC9uA72mr0j4AWB0awg (envelope-from ) for ; Mon, 27 Apr 2026 11:29:31 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=N8AqmKa9; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1884A1E0BA; Mon, 27 Apr 2026 11:29:31 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 12D9B1E067 for ; Mon, 27 Apr 2026 11:29:30 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id F1E304BB3B91 for ; Mon, 27 Apr 2026 15:29:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F1E304BB3B91 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=N8AqmKa9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 2A1594BB3B90 for ; Mon, 27 Apr 2026 15:28:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2A1594BB3B90 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2A1594BB3B90 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777303716; cv=none; b=YSfLFPdQZ1xp9aa7uYAcXPMTO/8AnPTDYuztonkcefqOTux7jvwZ3TPrZpHN6v7SJAaFyVF1VblyAvgWc96KQQu4KhHUAyQuqiDZMuWwJ0e0haBK7d7coRDB2Y4VYZkvwzZ1q44alNjBuBS3QCUcFZz92aCwkEQCPX1zui5JED0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777303716; c=relaxed/simple; bh=gKtUIURd7WirpOI6L3ly6E1uQUQOTN/9ZjCtqtvy8vs=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=YhrYZaB9kNI03U6HcWM5Te+RK80gt4M8if8TFvqZ8kDf2XMkzzR2QFsZFbuyjoQuFAVFMrUmxb0mddf/oJxYm7AfXPsfVYVrSR8VOO8oRr/zQzDlOxLKifhplBn09s9odQsZLabw368PmeL7YihV4HCWDTpDNyrbpZSPUJPEwe0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2A1594BB3B90 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777303715; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wnmmQ9MWgCL7I8Zqhdi2QQh3tyAhD4s/bbjIRCwv/38=; b=N8AqmKa9SZG6l/XDgWJd/h7/Lct0V4CBUyCJ0fIw3IhIIS8IohJrw6dqAZQY1eF2cFTpMc gweuuo0HzIEOTfRsBBoZhujCE8b97D6lZHYUcRmPzxZUghAcjO2YBCxDefsHwiERRPAEW/ uTHdUHSlaWfGJQ2GDpCcup+YriUnDaU= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-255-4g_OIFIcN12hyrMEpktdUg-1; Mon, 27 Apr 2026 11:28:34 -0400 X-MC-Unique: 4g_OIFIcN12hyrMEpktdUg-1 X-Mimecast-MFC-AGG-ID: 4g_OIFIcN12hyrMEpktdUg_1777303712 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-35fbb57764aso12118175a91.1 for ; Mon, 27 Apr 2026 08:28:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777303712; x=1777908512; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wnmmQ9MWgCL7I8Zqhdi2QQh3tyAhD4s/bbjIRCwv/38=; b=Q3QNbpNcD1Ov861Z6eOUlfmvlzmi0K0EP35t55GkNByDEe2CcLuN1sPKfxogtjb/c4 t4laCxMnocGGkbEwUCEqwDfMgOHw8HoTXiPSVNnuZmpUHB1vSF/7+kbzzSq0pQIxztra KBCj4rbiPp3gSug8czEhy5O5BnHVeD7iJGhEDkiQ6KdstKy0eTYkvom2CK7vRodMWfIg 3V4lsa0CNGiFvK3NpKZ8gDfK9FrpiMxxkh/8tZeYClTgX/ad5OuvwVZXakgJo+VMH7ap eljq5UElxrNGHXqaBAOGpNnMt7KOvDYmyjxQKIVwQOCLFZrgd9L5S2yQv3BbTB4Jca41 SxGA== X-Gm-Message-State: AOJu0Yx58pAcmbuOUzYoZ1eGgt3lTHFFZiLbrsYkVQk6kwxy4Wopgg6W f8m9Ip7uDNtbm4lYugV1G1MugN3K/T5H5LvBFkjlDHUl/FlLIgP+9JhBAGl+QJdT4A05uj1NcGt QtqpBfRCdv9WqTqGoB0Qq19yE/ZV0dLdCR7CDuhdn7g0VK9D+DWehdhSo9Ys6jMQ= X-Gm-Gg: AeBDies1YY51r7EMfiDYCqk72Y/RLXomPoU+IyDFmEoT60O843BE7GgVDHgxh+1PoXq bVyEFWWVSbxTYHFFr5pBUdCgH3aAGwGpVa25loKpJf4gDvJbMfo3uWvAVERv70zs76vdOJChWfM Af8CG6bSH5nTK7f7Y6Klv3+490OYBHZla/sv34kEfASbl7AWteqRlz8AQNEQigt7VN90w2EWm// mGqFc3JK1vkYnEP94cFlPpOKPSnFWlDlab5M2iDrJuQ8FC24GDwFyJCB40wjvUiFyfabvb3VRzi NuUrCvPg94167P7m0fN0iRG5ZfWeguDHmNf5zNr8IoNkOqRF7VTTfRvq2JcI3tnFySggLMu+Aq2 eHDcDkptFo/xb13wTEY7Rz4q4AF6eiAK8jAY5lEE= X-Received: by 2002:a17:90b:510e:b0:35d:a1ce:c1 with SMTP id 98e67ed59e1d1-361401f8290mr38901029a91.8.1777303712401; Mon, 27 Apr 2026 08:28:32 -0700 (PDT) X-Received: by 2002:a17:90b:510e:b0:35d:a1ce:c1 with SMTP id 98e67ed59e1d1-361401f8290mr38901012a91.8.1777303711948; Mon, 27 Apr 2026 08:28:31 -0700 (PDT) Received: from [150.1.200.157] ([172.56.107.181]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c797701b0f0sm25862420a12.17.2026.04.27.08.28.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Apr 2026 08:28:31 -0700 (PDT) Message-ID: <72021792-2f5a-47a4-a3aa-8141ae2e2bee@redhat.com> Date: Mon, 27 Apr 2026 08:28:30 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] gdb/symtab.c Fix completion of template class members To: Daniel Knezevic Cc: "gdb-patches@sourceware.org" References: <44171ae9-cd60-4c6d-950d-30276cd489eb@redhat.com> <20260420120310.64156-1-daniel.knezevic@htecgroup.com> From: Keith Seitz In-Reply-To: <20260420120310.64156-1-daniel.knezevic@htecgroup.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _bAuACyNIF4c_qCnlQt9A1Decr7hTwOMK6rQd62j5Co_1777303712 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/20/26 5:03 AM, Daniel Knezevic wrote: > Hi, > > Is there anything I need to change for this patch? > > I have updated the patch based on Keith's comments that you can find bellow: You've addressed all my comments, so this LGTM. Just to reiterate: Reviewed-By: Keith Seitz Thank you for the patch and your patience. Keith