From: Tom de Vries <tdevries@suse.de>
To: Andreas Arnez <arnez@linux.ibm.com>, Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org, Alan Hayward <alan.hayward@arm.com>,
Andrew Burgess <andrew.burgess@embecosm.com>
Subject: Re: [PATCH] gdb/testsuite: Fix typos in infcall-nested-structs.c
Date: Thu, 10 Oct 2019 15:23:00 -0000 [thread overview]
Message-ID: <7004ea74-1aeb-112c-ee24-a0042423e0a4@suse.de> (raw)
In-Reply-To: <m336g07v1t.fsf@oc0404454431.ibm.com>
On 10-10-2019 12:29, Andreas Arnez wrote:
> On Wed, Oct 09 2019, Tom Tromey wrote:
>
>>>>>>> "Andreas" == Andreas Arnez <arnez@linux.ibm.com> writes:
>
> [...]
>
>> Andreas> gdb/testsuite/ChangeLog:
>>
>> Andreas> * gdb.base/infcall-nested-structs.c (cmp_struct_02_01)
>> Andreas> (cmp_struct_02_02, cmp_struct_04_01, cmp_struct_04_02)
>> Andreas> (cmp_struct_05_01, cmp_struct_static_02_01)
>> Andreas> (cmp_struct_static_04_01, cmp_struct_static_06_01): Fix redundant
>> Andreas> comparisons.
>>
>> Thank you. This looks reasonable to me. I think you could have put it
>> in under the obvious rule, even.
>
> Yeah, this does seem obvious... Thanks anyway!
>
Hi,
I see these new failures on x86_64-linux:
...
FAIL: gdb.base/infcall-nested-structs.exp: l=c++: types-tc-tf: p/d
check_arg_struct_02_01 (ref_val_struct_02_01)
FAIL: gdb.base/infcall-nested-structs.exp: l=c++: types-ts-tf: p/d
check_arg_struct_02_01 (ref_val_struct_02_01)
FAIL: gdb.base/infcall-nested-structs.exp: l=c++: types-ti-tf: p/d
check_arg_struct_02_01 (ref_val_struct_02_01)
...
Thanks,
- Tom
next prev parent reply other threads:[~2019-10-10 15:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 11:25 Andreas Arnez
2019-10-09 17:58 ` Tom Tromey
2019-10-10 10:29 ` Andreas Arnez
2019-10-10 15:23 ` Tom de Vries [this message]
2019-10-10 17:24 ` Andreas Arnez
2019-10-10 18:30 ` Tom de Vries
2019-10-10 20:26 ` Tom de Vries
2019-10-10 21:07 ` Tom de Vries
2019-10-11 12:19 ` Tom de Vries
2019-10-12 11:49 ` [PATCH][gdb/tdep] Fix inferior call arg passing for amd64 Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7004ea74-1aeb-112c-ee24-a0042423e0a4@suse.de \
--to=tdevries@suse.de \
--cc=alan.hayward@arm.com \
--cc=andrew.burgess@embecosm.com \
--cc=arnez@linux.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox