From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30947 invoked by alias); 10 Oct 2019 15:23:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30937 invoked by uid 89); 10 Oct 2019 15:23:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Oct 2019 15:23:54 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 5574EAFCB; Thu, 10 Oct 2019 15:23:52 +0000 (UTC) Subject: Re: [PATCH] gdb/testsuite: Fix typos in infcall-nested-structs.c To: Andreas Arnez , Tom Tromey Cc: gdb-patches@sourceware.org, Alan Hayward , Andrew Burgess References: <87lfttdcmv.fsf@tromey.com> From: Tom de Vries Message-ID: <7004ea74-1aeb-112c-ee24-a0042423e0a4@suse.de> Date: Thu, 10 Oct 2019 15:23:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-10/txt/msg00277.txt.bz2 On 10-10-2019 12:29, Andreas Arnez wrote: > On Wed, Oct 09 2019, Tom Tromey wrote: > >>>>>>> "Andreas" == Andreas Arnez writes: > > [...] > >> Andreas> gdb/testsuite/ChangeLog: >> >> Andreas> * gdb.base/infcall-nested-structs.c (cmp_struct_02_01) >> Andreas> (cmp_struct_02_02, cmp_struct_04_01, cmp_struct_04_02) >> Andreas> (cmp_struct_05_01, cmp_struct_static_02_01) >> Andreas> (cmp_struct_static_04_01, cmp_struct_static_06_01): Fix redundant >> Andreas> comparisons. >> >> Thank you. This looks reasonable to me. I think you could have put it >> in under the obvious rule, even. > > Yeah, this does seem obvious... Thanks anyway! > Hi, I see these new failures on x86_64-linux: ... FAIL: gdb.base/infcall-nested-structs.exp: l=c++: types-tc-tf: p/d check_arg_struct_02_01 (ref_val_struct_02_01) FAIL: gdb.base/infcall-nested-structs.exp: l=c++: types-ts-tf: p/d check_arg_struct_02_01 (ref_val_struct_02_01) FAIL: gdb.base/infcall-nested-structs.exp: l=c++: types-ti-tf: p/d check_arg_struct_02_01 (ref_val_struct_02_01) ... Thanks, - Tom