From: Pedro Alves <palves@redhat.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/3] Remove single-step breakpoint for GDBserver internal event
Date: Thu, 27 Oct 2016 13:16:00 -0000 [thread overview]
Message-ID: <6feb876a-46d2-4ef8-e75d-6de9550b4c0f@redhat.com> (raw)
In-Reply-To: <CAH=s-PPOdSfxKGuHd3QagxOvGheiq+MiR7z28ZRiZj_tv62cgA@mail.gmail.com>
On 10/26/2016 09:14 PM, Yao Qi wrote:
> On Wed, Oct 26, 2016 at 1:45 PM, Pedro Alves <palves@redhat.com> wrote:
>> On 09/26/2016 03:25 AM, Yao Qi wrote:
>>> This patch removes single-step breakpoints if the event is only
>>> GDBserver internal, IOW, isn't reported back to GDB.
>>
>> Can you expand on rationale? Why does being internal matter?
>
> We remove single-step breakpoints on the moment we report event
> back to GDB. However, if we use single-step breakpoints and get
> some events, we don't report them back to GDB and keep controlling
> the inferior, we need to remove single-step breakpoints. For
> example, in range stepping, until the program goes out of the range,
> we keep doing single step (by software), in a loop of insert single-step
> breakpoints, resume, remove them.
>
Ah yes, sorry, I should have read the code in more detail.
I agree, totally makes sense to do this here.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-10-27 13:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 2:25 [PATCH 0/3] Support range stepping on software single-step target Yao Qi
2016-09-26 2:25 ` [PATCH 2/3] Get pending events in random Yao Qi
2016-09-26 2:25 ` [PATCH 3/3] Enable range stepping if software single step is supported Yao Qi
2016-09-26 2:47 ` [PATCH 1/3] Remove single-step breakpoint for GDBserver internal event Yao Qi
2016-10-26 17:45 ` Pedro Alves
2016-10-26 20:14 ` Yao Qi
2016-10-27 13:16 ` Pedro Alves [this message]
2016-10-27 14:14 ` Yao Qi
2016-10-27 14:14 ` Pedro Alves
2016-10-10 8:43 ` [PATCH 0/3] Support range stepping on software single-step target Yao Qi
2016-10-26 15:39 ` Yao Qi
2016-10-26 17:34 ` Antoine Tremblay
2016-10-27 15:07 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6feb876a-46d2-4ef8-e75d-6de9550b4c0f@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox