From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129685 invoked by alias); 27 Oct 2016 13:16:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129525 invoked by uid 89); 27 Oct 2016 13:16:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Oct 2016 13:16:55 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A8A0A80E4A; Thu, 27 Oct 2016 13:16:54 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9RDGrGI010595; Thu, 27 Oct 2016 09:16:54 -0400 Subject: Re: [PATCH 1/3] Remove single-step breakpoint for GDBserver internal event To: Yao Qi References: <1474856716-5913-1-git-send-email-yao.qi@linaro.org> <1474856716-5913-2-git-send-email-yao.qi@linaro.org> Cc: "gdb-patches@sourceware.org" From: Pedro Alves Message-ID: <6feb876a-46d2-4ef8-e75d-6de9550b4c0f@redhat.com> Date: Thu, 27 Oct 2016 13:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00749.txt.bz2 On 10/26/2016 09:14 PM, Yao Qi wrote: > On Wed, Oct 26, 2016 at 1:45 PM, Pedro Alves wrote: >> On 09/26/2016 03:25 AM, Yao Qi wrote: >>> This patch removes single-step breakpoints if the event is only >>> GDBserver internal, IOW, isn't reported back to GDB. >> >> Can you expand on rationale? Why does being internal matter? > > We remove single-step breakpoints on the moment we report event > back to GDB. However, if we use single-step breakpoints and get > some events, we don't report them back to GDB and keep controlling > the inferior, we need to remove single-step breakpoints. For > example, in range stepping, until the program goes out of the range, > we keep doing single step (by software), in a loop of insert single-step > breakpoints, resume, remove them. > Ah yes, sorry, I should have read the code in more detail. I agree, totally makes sense to do this here. Thanks, Pedro Alves