From: Simon Marchi <simark@simark.ca>
To: Andrey Utkin <autkin@undo.io>
Cc: John Baldwin <jhb@freebsd.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix search of debug files for remote debuggee
Date: Wed, 02 Jan 2019 19:54:00 -0000 [thread overview]
Message-ID: <6ee6437fdc634c436fcd00d5146545d0@simark.ca> (raw)
In-Reply-To: <20190102181153.GA32677@undo-autkin>
On 2019-01-02 13:11, Andrey Utkin wrote:
> On Mon, Dec 24, 2018 at 11:26:05AM -0500, Simon Marchi wrote:
>> Andrey, I would make a few minor changes to your patch, if you agree:
>>
>> - Use "startswith" instead of strncmp
>> - Use strlen instead of magical number 7
>> - Use ternary operator
>> - Change variable name "remote" to "target_prefix".
>>
>> This would be the result:
>
> Thanks for improving the patch.
> Everything looks great now. Please apply.
Thanks, I just pushed it.
Simon
next prev parent reply other threads:[~2019-01-02 19:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 19:09 Andrey Utkin
2018-11-09 19:42 ` John Baldwin
2018-11-09 23:32 ` Andrey Utkin
2018-12-24 16:26 ` Simon Marchi
2019-01-02 18:11 ` Andrey Utkin
2019-01-02 19:54 ` Simon Marchi [this message]
2018-11-17 18:52 ` Andrey Utkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ee6437fdc634c436fcd00d5146545d0@simark.ca \
--to=simark@simark.ca \
--cc=autkin@undo.io \
--cc=gdb-patches@sourceware.org \
--cc=jhb@freebsd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox