From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72842 invoked by alias); 2 Jan 2019 19:54:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72831 invoked by uid 89); 2 Jan 2019 19:54:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=H*F:D*ca, H*UA:Roundcube, H*u:Roundcube, H*u:1.3.6 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 02 Jan 2019 19:54:00 +0000 Received: by simark.ca (Postfix, from userid 112) id D87981E7B3; Wed, 2 Jan 2019 14:53:58 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 0971F1E4B1; Wed, 2 Jan 2019 14:53:56 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 02 Jan 2019 19:54:00 -0000 From: Simon Marchi To: Andrey Utkin Cc: John Baldwin , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix search of debug files for remote debuggee In-Reply-To: <20190102181153.GA32677@undo-autkin> References: <20181109190940.22554-1-autkin@undo.io> <10046787-753c-f7e0-4386-2b50086ae530@FreeBSD.org> <5c1211f6-0e75-d225-158a-0e6a310b68c7@simark.ca> <20190102181153.GA32677@undo-autkin> Message-ID: <6ee6437fdc634c436fcd00d5146545d0@simark.ca> X-Sender: simark@simark.ca User-Agent: Roundcube Webmail/1.3.6 X-SW-Source: 2019-01/txt/msg00042.txt.bz2 On 2019-01-02 13:11, Andrey Utkin wrote: > On Mon, Dec 24, 2018 at 11:26:05AM -0500, Simon Marchi wrote: >> Andrey, I would make a few minor changes to your patch, if you agree: >> >> - Use "startswith" instead of strncmp >> - Use strlen instead of magical number 7 >> - Use ternary operator >> - Change variable name "remote" to "target_prefix". >> >> This would be the result: > > Thanks for improving the patch. > Everything looks great now. Please apply. Thanks, I just pushed it. Simon