Re: [PATCH v3][PR gdb/15559] Use thiscall calling convention for class members

[Simon Marchi <simark@simark.ca>]

On 2020-04-29 1:19 p.m., Hannes Domani via Gdb-patches wrote:
>  Am Mittwoch, 29. April 2020, 18:49:32 MESZ hat Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> Folgendes geschrieben:
> 
>> Am Mittwoch, 29. April 2020, 18:45:35 MESZ hat Simon Marchi <simark@simark.ca> Folgendes geschrieben:
>>
>>>> @@ -234,6 +264,8 @@ i386_windows_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
>>>>   {
>>>>     i386_windows_init_abi_common (info, gdbarch);
>>>>     windows_init_abi (info, gdbarch);
>>>> +
>>>> +  set_gdbarch_push_dummy_call (gdbarch, i386_windows_push_dummy_call);
>>>>   }
>>>
>>> Just to be sure, this call convention does not apply to Cygwin programs?
>>
>>
>> I don't really know, but you're right, I should find out.
>> I will install & test with a cygwin compiler tomorrow.
> 
> Installing cygwin went faster than I expected.
> 
> And yes, cygwin does NOT use thiscall calling convention.
> That just makes me more glad that now there exists a distinction between
> cygwin & non-cygwin programs in gdb.

Ok, the patch LGTM then.

Thanks,

Simon