From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id E1BBF38930CB
 for <gdb-patches@sourceware.org>; Wed, 29 Apr 2020 18:26:59 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E1BBF38930CB
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [10.0.0.193] (unknown [192.222.164.54])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 76E9F1F068;
 Wed, 29 Apr 2020 14:26:59 -0400 (EDT)
Subject: Re: [PATCH v3][PR gdb/15559] Use thiscall calling convention for
 class members
To: Hannes Domani <ssbssa@yahoo.de>, Gdb-patches <gdb-patches@sourceware.org>
References: <20200429134808.3642-1-ssbssa.ref@yahoo.de>
 <20200429134808.3642-1-ssbssa@yahoo.de>
 <f95391c2-1ed8-d28b-5a87-35e241fac2c0@simark.ca>
 <911174982.4511581.1588178963372@mail.yahoo.com>
 <45689522.4534618.1588180764080@mail.yahoo.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <6e8eebd7-eed7-11ac-dc8a-e1dfe5f2a47d@simark.ca>
Date: Wed, 29 Apr 2020 14:26:59 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <45689522.4534618.1588180764080@mail.yahoo.com>
Content-Type: text/plain; charset=utf-8
Content-Language: tl
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Apr 2020 18:27:01 -0000

On 2020-04-29 1:19 p.m., Hannes Domani via Gdb-patches wrote:
>  Am Mittwoch, 29. April 2020, 18:49:32 MESZ hat Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> Folgendes geschrieben:
> 
>> Am Mittwoch, 29. April 2020, 18:45:35 MESZ hat Simon Marchi <simark@simark.ca> Folgendes geschrieben:
>>
>>>> @@ -234,6 +264,8 @@ i386_windows_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
>>>>   {
>>>>     i386_windows_init_abi_common (info, gdbarch);
>>>>     windows_init_abi (info, gdbarch);
>>>> +
>>>> +  set_gdbarch_push_dummy_call (gdbarch, i386_windows_push_dummy_call);
>>>>   }
>>>
>>> Just to be sure, this call convention does not apply to Cygwin programs?
>>
>>
>> I don't really know, but you're right, I should find out.
>> I will install & test with a cygwin compiler tomorrow.
> 
> Installing cygwin went faster than I expected.
> 
> And yes, cygwin does NOT use thiscall calling convention.
> That just makes me more glad that now there exists a distinction between
> cygwin & non-cygwin programs in gdb.

Ok, the patch LGTM then.

Thanks,

Simon