Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Handle dereferencing Rust trait objects
Date: Fri, 17 Nov 2017 15:39:00 -0000	[thread overview]
Message-ID: <6e8eba3f-938d-fa8a-2f34-fe63f1187470@redhat.com> (raw)
In-Reply-To: <87fu9d95r1.fsf@tromey.com>


On 11/16/2017 11:13 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
> Tom> I wasn't sure if I ought to xfail the new tests.  I have the impression
> Tom> that I'm the only person who runs the Rust gdb tests, but I'm not
> Tom> actually certain.
> 
> Pedro> I run the rust tests with whatever's the rust compiler that comes
> Pedro> with Fedora:
> 
> Thanks for doing that.
> 
> I'm not sure what my options are for the test.  I could probably predict
> what version of rustc will have the patches -- but this also requires a
> patched LLVM, and while both the upstream LLVM and rust-llvm have the
> patch, people are free to build against other versions (and I don't know
> what the distros do in particular).

Dunno.  Maybe do something like gdb.arch/altivec-abi.exp, using readelf
to look for some DWARf tag:

    if { "$force_abi" == "auto" } {
        # If the toolchain does not record attributes, skip auto-ABI tests.
        set readelf_program [gdb_find_readelf]
        set result [catch "exec $readelf_program -A $binfile" output]

        if {$result == 0 && ![regexp Tag_GNU_Power_ABI_Vector $output]} {
            untested "ABI not marked"
            return
        }
    }

Thanks,
Pedro Alves


  reply	other threads:[~2017-11-17 15:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-15 21:24 Tom Tromey
2017-11-15 21:28 ` Tom Tromey
2017-11-16 16:40   ` Pedro Alves
2017-11-16 23:13     ` Tom Tromey
2017-11-17 15:39       ` Pedro Alves [this message]
2017-11-16 16:35 ` Pedro Alves
2017-11-16 23:26   ` Tom Tromey
2017-11-17 17:30     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e8eba3f-938d-fa8a-2f34-fe63f1187470@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox