From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-143469-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 5624 invoked by alias); 17 Nov 2017 15:39:29 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 5162 invoked by uid 89); 17 Nov 2017 15:39:29 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=person
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Nov 2017 15:39:28 +0000
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 6E78B7EAAA;	Fri, 17 Nov 2017 15:39:27 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by smtp.corp.redhat.com (Postfix) with ESMTP id 904297C1A7;	Fri, 17 Nov 2017 15:39:26 +0000 (UTC)
Subject: Re: [RFA] Handle dereferencing Rust trait objects
To: Tom Tromey <tom@tromey.com>
References: <20171115212403.8639-1-tom@tromey.com> <87o9o38c5k.fsf@tromey.com> <08c0e477-ab7c-490c-fcc9-2e68a60a3c70@redhat.com> <87fu9d95r1.fsf@tromey.com>
Cc: gdb-patches@sourceware.org
From: Pedro Alves <palves@redhat.com>
Message-ID: <6e8eba3f-938d-fa8a-2f34-fe63f1187470@redhat.com>
Date: Fri, 17 Nov 2017 15:39:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <87fu9d95r1.fsf@tromey.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-11/txt/msg00341.txt.bz2


On 11/16/2017 11:13 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
> Tom> I wasn't sure if I ought to xfail the new tests.  I have the impression
> Tom> that I'm the only person who runs the Rust gdb tests, but I'm not
> Tom> actually certain.
> 
> Pedro> I run the rust tests with whatever's the rust compiler that comes
> Pedro> with Fedora:
> 
> Thanks for doing that.
> 
> I'm not sure what my options are for the test.  I could probably predict
> what version of rustc will have the patches -- but this also requires a
> patched LLVM, and while both the upstream LLVM and rust-llvm have the
> patch, people are free to build against other versions (and I don't know
> what the distros do in particular).

Dunno.  Maybe do something like gdb.arch/altivec-abi.exp, using readelf
to look for some DWARf tag:

    if { "$force_abi" == "auto" } {
        # If the toolchain does not record attributes, skip auto-ABI tests.
        set readelf_program [gdb_find_readelf]
        set result [catch "exec $readelf_program -A $binfile" output]

        if {$result == 0 && ![regexp Tag_GNU_Power_ABI_Vector $output]} {
            untested "ABI not marked"
            return
        }
    }

Thanks,
Pedro Alves