From: Luis Machado <luis.machado@linaro.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org, Alan.Hayward@arm.com
Subject: Re: [PATCH] [AArch64] Fix erroneous use of spu architecture bfd
Date: Sun, 05 Jan 2020 12:00:00 -0000 [thread overview]
Message-ID: <6e27a649-1e39-b124-f5f2-ab883800387c@linaro.org> (raw)
In-Reply-To: <20200105062746.GC12588@adacore.com>
On 1/5/20 3:27 AM, Joel Brobecker wrote:
> Hi Luis,
>
>> While investigating some SVE code, i noticed the use of two spu bfd variables.
>>
>> This looks like an oversight, as the "id" field is available for non-spu
>> architectures as well, even though its primary use was the Cell BE
>> architecture.
>>
>> The following patch fixes this.
>>
>> gdb/ChangeLog:
>>
>> 2020-01-03 Luis Machado <luis.machado@linaro.org>
>>
>> * aarch64-linux-nat.c
>> (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
>> and bfd_mach_aarch64.
>>
>> Change-Id: I817673e9a12cadfa88638870f0ff524241cf6a34
>
>
> I think the patch looks pretty clear to me ;-), so you can go ahead
> and push.
>
> Or perhaps, before doing so: Since the Gerrit experiment is being
> put on hold, you might want to remove your commit hook, and then
> remove the "Change-Id" field above...
Done now.
>
> Thanks for the patch >
Pushed to master. Thanks!
prev parent reply other threads:[~2020-01-05 12:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 19:15 Luis Machado
2020-01-05 6:27 ` Joel Brobecker
2020-01-05 12:00 ` Luis Machado [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e27a649-1e39-b124-f5f2-ab883800387c@linaro.org \
--to=luis.machado@linaro.org \
--cc=Alan.Hayward@arm.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox