From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114023 invoked by alias); 5 Jan 2020 12:00:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113856 invoked by uid 89); 5 Jan 2020 12:00:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-qt1-f169.google.com Received: from mail-qt1-f169.google.com (HELO mail-qt1-f169.google.com) (209.85.160.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 05 Jan 2020 12:00:02 +0000 Received: by mail-qt1-f169.google.com with SMTP id l12so40357424qtq.12 for ; Sun, 05 Jan 2020 04:00:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=u0Oy8l0qlTojwgL2L3DL+6OYOdExn+lK5yNEtY/cQqY=; b=bFAq+Y943L6xtLyvvlHRuHkaajdogikH1oHmxKlSIMKopfgvmkp3u2MAeZvuuINlGY 9El18EVoPqfCQDHjXjGQ9qecT6r4HEor8QIltiSYUNMLajCSsQp3Jh6W0oIxGbCAoaiD dcexvhAC4/x7fZYtR3ryqIWlSbFT62SlbQTmaFkmZFPs3lQWAxd5TbzzcAJavAIr9hrf iKKRMuiG2/0LszReVeYIm/YW0ciWb4damjyrbrt6MPxF/4pSj+esjTm9k+WK2XiDNLJf kkfAM8PMqyPgvNYvlX82FEF9FZDWm9gx5KaZHbx2GSPbkRbY8daTpoJdHCEGcb1FJYXv UB+Q== Return-Path: Received: from [192.168.0.185] ([191.34.155.77]) by smtp.gmail.com with ESMTPSA id g18sm21939527qtc.83.2020.01.05.03.59.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Jan 2020 03:59:59 -0800 (PST) Subject: Re: [PATCH] [AArch64] Fix erroneous use of spu architecture bfd To: Joel Brobecker Cc: gdb-patches@sourceware.org, Alan.Hayward@arm.com References: <20200103191512.28770-1-luis.machado@linaro.org> <20200105062746.GC12588@adacore.com> From: Luis Machado Message-ID: <6e27a649-1e39-b124-f5f2-ab883800387c@linaro.org> Date: Sun, 05 Jan 2020 12:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200105062746.GC12588@adacore.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00095.txt.bz2 On 1/5/20 3:27 AM, Joel Brobecker wrote: > Hi Luis, > >> While investigating some SVE code, i noticed the use of two spu bfd variables. >> >> This looks like an oversight, as the "id" field is available for non-spu >> architectures as well, even though its primary use was the Cell BE >> architecture. >> >> The following patch fixes this. >> >> gdb/ChangeLog: >> >> 2020-01-03 Luis Machado >> >> * aarch64-linux-nat.c >> (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64 >> and bfd_mach_aarch64. >> >> Change-Id: I817673e9a12cadfa88638870f0ff524241cf6a34 > > > I think the patch looks pretty clear to me ;-), so you can go ahead > and push. > > Or perhaps, before doing so: Since the Gerrit experiment is being > put on hold, you might want to remove your commit hook, and then > remove the "Change-Id" field above... Done now. > > Thanks for the patch > Pushed to master. Thanks!