Re: [PATCH] arc: Write correct "eret" value during register collection

[Shahab Vahedi via Gdb-patches <gdb-patches@sourceware.org>]

Hi Tom,

On 11/12/20 3:36 PM, Tom Tromey wrote:
>>>>>> "Shahab" == Shahab Vahedi via Gdb-patches <gdb-patches@sourceware.org> writes:
> Shahab>    /* Skip non-existing registers.  */
> Shahab> -  if ((arc_linux_core_reg_offsets[regnum] == ARC_OFFSET_NO_REGISTER))
> Shahab> +  if (arc_linux_core_reg_offsets[regnum] == ARC_OFFSET_NO_REGISTER)
> Shahab>      return;
> Shahab> +  else
> Shahab> +    offset = arc_linux_core_reg_offsets[ARC_ERET_REGNUM];
> 
> I would drop the "else" here.

done.

> 
> I didn't understand this patch.  It unconditionally sets 'offset' to the
> offset of ARC_ERET_REGNUM.  But surely that can't be correct?
> The assignment above does this, and so does...
> 
> Shahab>    if (regnum == gdbarch_pc_regnum (gdbarch))
> Shahab> -    regnum = ARC_ERET_REGNUM;
> Shahab> -  regcache->raw_collect (regnum, buf + arc_linux_core_reg_offsets[regnum]);
> Shahab> +    offset = arc_linux_core_reg_offsets[ARC_ERET_REGNUM];
> 
> ... this one.

You're absolutely correct.  That was a snafu on my side.  A second patch is submitted [1].

[1] [PATCH v2] arc: Write correct "eret" value during register collection
https://sourceware.org/pipermail/gdb-patches/2020-November/173212.html


Cheers,
Shahab