From: "H.J. Lu" <hjl.tools@gmail.com>
To: tromey@redhat.com
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>,
Joel Brobecker <brobecker@adacore.com>,
GDB <gdb-patches@sourceware.org>
Subject: Re: RFC: Support DW_TAG_entry_point
Date: Thu, 23 Apr 2009 23:49:00 -0000 [thread overview]
Message-ID: <6dc9ffc80904231649r37d4d106h7aece220a945a2d0@mail.gmail.com> (raw)
In-Reply-To: <m3vdovos1y.fsf@fleche.redhat.com>
On Thu, Apr 23, 2009 at 4:42 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
>
> Jan> I guess the whole patch tagets just one compiler's (ifort's?) use
> Jan> of DW_TAG_entry_point. DWARF standard also says neither that
> Jan> DW_TAG_entry_point should be a child of DW_TAG_subprogram nor
> Jan> that it should not have its own DW_AT_high_pc. Therefore
> Jan> assuming DW_TAG_entry_point will be the first child DIE is
> Jan> ensured for the target compiler this patch was made for.
>
> Ok, I went and looked through DWARF 3 again to try to understand more.
>
> I think this means that the compiler in question is emitting invalid
> DWARF, or at least using its own extension. In that case I suppose I
> would be more inclined to allow this, provided that it doesn't impact
> the possibility of correctly implementing DW_TAG_entry_point in the
> future (maybe the patch already does this too, I really don't know).
I will take a look.
> Assuming this is an extension, I would like a comment to that effect,
> mentioning the compiler. A test case wouldn't hurt, either.
>
I do have a testcase. But you need ifort to use it.
--
H.J.
next prev parent reply other threads:[~2009-04-23 23:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-20 22:15 H.J. Lu
2009-03-21 1:02 ` Tom Tromey
2009-03-21 16:25 ` H.J. Lu
2009-03-23 18:26 ` Tom Tromey
2009-03-23 19:09 ` H.J. Lu
2009-04-22 21:13 ` Tom Tromey
2009-04-23 10:58 ` Joel Brobecker
2009-04-23 11:10 ` Jan Kratochvil
2009-04-23 23:43 ` Tom Tromey
2009-04-23 23:49 ` H.J. Lu [this message]
2009-04-24 0:13 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dc9ffc80904231649r37d4d106h7aece220a945a2d0@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox