From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: "H.J. Lu" <hjl.tools@gmail.com>, GDB <gdb-patches@sourceware.org>
Subject: Re: RFC: Support DW_TAG_entry_point
Date: Thu, 23 Apr 2009 10:58:00 -0000 [thread overview]
Message-ID: <20090423061003.GA7552@adacore.com> (raw)
In-Reply-To: <m3hc0gv1c8.fsf@fleche.redhat.com>
> HJ> I have a patch to support DW_TAG_entry_point.
>
> I don't really understand most of this patch; perhaps someone more
> familiar with dwarf2read.c could review it.
I started reviewing it a while ago, but never got to the end of it.
> However:
>
> HJ> + /* A DW_TAG_subprogram DIE may have DW_TAG_entry_point DIEs
> HJ> + as children. */
> HJ> + if (pdi->tag == DW_TAG_subprogram
> HJ> + && pdi->has_children
> HJ> + && pdi->die_child
> HJ> + && pdi->die_child->tag == DW_TAG_entry_point)
> HJ> + scan_partial_symbols (pdi->die_child, lowpc, highpc, cu);
>
> This looks strange to me. IIUC, there's no requirement that
> DW_TAG_entry_point be the first child.
That was my main observation at the time.
--
Joel
next prev parent reply other threads:[~2009-04-23 10:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-20 22:15 H.J. Lu
2009-03-21 1:02 ` Tom Tromey
2009-03-21 16:25 ` H.J. Lu
2009-03-23 18:26 ` Tom Tromey
2009-03-23 19:09 ` H.J. Lu
2009-04-22 21:13 ` Tom Tromey
2009-04-23 10:58 ` Joel Brobecker [this message]
2009-04-23 11:10 ` Jan Kratochvil
2009-04-23 23:43 ` Tom Tromey
2009-04-23 23:49 ` H.J. Lu
2009-04-24 0:13 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090423061003.GA7552@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox