From: Tom de Vries <tdevries@suse.de>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb] Write index for dwz -m file
Date: Mon, 13 May 2019 12:22:00 -0000 [thread overview]
Message-ID: <6cb63aac-2375-18ee-adaf-2bb9f7a0b355@suse.de> (raw)
In-Reply-To: <90892dae-b6b9-6a89-7cee-bbed859c207b@polymtl.ca>
On 11-05-19 04:36, Simon Marchi wrote:
> @@ -122,12 +144,13 @@ index_cache::store (struct dwarf2_per_objfile *dwarf2_per_objfile)
>
> if (debug_index_cache)
> printf_unfiltered ("index cache: writing index cache for objfile %s\n",
> - objfile_name (obj));
> + objfile_name (obj));
>
> /* Write the index itself to the directory, using the build id as the
> filename. */
LGTM.
[ I'm not sure if this white-space-only change should be included though. ]
Thanks,
- Tom
next prev parent reply other threads:[~2019-05-13 12:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 14:42 Tom de Vries
2019-05-07 16:13 ` [RFC, gdb/contrib] Fix gdb/contrib/gdb-add-index.sh for dwz-m-ed execs Tom de Vries
2019-05-12 19:49 ` Simon Marchi
2019-05-13 10:47 ` Tom de Vries
2019-06-10 18:41 ` [PATCH, " Tom de Vries
2019-06-16 17:41 ` Simon Marchi
2019-05-11 2:36 ` [PATCH][gdb] Write index for dwz -m file Simon Marchi
2019-05-13 12:22 ` Tom de Vries [this message]
2019-05-13 13:56 ` Simon Marchi
2019-06-16 10:43 ` [PING][PATCH][gdb] " Tom de Vries
2019-06-16 17:22 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cb63aac-2375-18ee-adaf-2bb9f7a0b355@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox