From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84290 invoked by alias); 13 May 2019 12:22:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84280 invoked by uid 89); 13 May 2019 12:22:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,SPF_PASS autolearn=ham version=3.3.1 spammy=H*f:sk:90892da, H*i:sk:90892da X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 May 2019 12:22:14 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 33E4AAF5F; Mon, 13 May 2019 12:22:12 +0000 (UTC) Subject: Re: [PATCH][gdb] Write index for dwz -m file To: Simon Marchi , gdb-patches@sourceware.org References: <20190507144207.GA17626@delia> <90892dae-b6b9-6a89-7cee-bbed859c207b@polymtl.ca> From: Tom de Vries Message-ID: <6cb63aac-2375-18ee-adaf-2bb9f7a0b355@suse.de> Date: Mon, 13 May 2019 12:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <90892dae-b6b9-6a89-7cee-bbed859c207b@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00297.txt.bz2 On 11-05-19 04:36, Simon Marchi wrote: > @@ -122,12 +144,13 @@ index_cache::store (struct dwarf2_per_objfile *dwarf2_per_objfile) > > if (debug_index_cache) > printf_unfiltered ("index cache: writing index cache for objfile %s\n", > - objfile_name (obj)); > + objfile_name (obj)); > > /* Write the index itself to the directory, using the build id as the > filename. */ LGTM. [ I'm not sure if this white-space-only change should be included though. ] Thanks, - Tom