From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Return iteration_status from iterate_over_objfiles_in_search_order_cb_ftype
Date: Tue, 5 May 2026 13:13:28 -0400 [thread overview]
Message-ID: <6c186838-6046-4781-b90b-dac816279879@simark.ca> (raw)
In-Reply-To: <20260505150228.474870-1-tromey@adacore.com>
> @@ -631,26 +631,26 @@ gdbpy_lookup_objfile (PyObject *self, PyObject *args, PyObject *kw)
> {
> /* Don't return separate debug files. */
> if (obj->separate_debug_objfile_backlink != nullptr)
> - return false;
> + return iteration_status::keep_going;
>
> if ((obj->flags & OBJF_NOT_FILENAME) != 0)
> - return false;
> + return iteration_status::keep_going;
>
> const char *filename = objfile_filename (obj);
> if (filename != NULL
> && compare_filenames_for_search (filename, name))
> {
> objfile = obj;
> - return true;
> + return iteration_status::keep_going;
> }
>
> if (compare_filenames_for_search (obj->original_name, name))
> {
> objfile = obj;
> - return true;
> + return iteration_status::keep_going;
> }
These last two look wrong.
Other than that, LGTM.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
next prev parent reply other threads:[~2026-05-05 17:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 15:02 Tom Tromey
2026-05-05 17:13 ` Simon Marchi [this message]
2026-05-05 17:14 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c186838-6046-4781-b90b-dac816279879@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox