From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id D0SHNGAl+mmnChcAWB0awg (envelope-from ) for ; Tue, 05 May 2026 13:14:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1778001248; bh=DQjGSpNKjKVVgJeXAd0PoVsQhFVBfGnjKRP0vDYOgXA=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=iHC+ynDpxC5zigJ6/dTVru1DeKUR0UXK0aA4GhlP0MJh2q0H5HsG1FL9sw81ZKnuB NZy0k+rh8y/sUrnUB/gCzgSPrKSOfuyi8Go89HXFTsXXxeIJw7bNS1zA8S3osTxaMB OFCV5lApuJ5JiMgHFn7regiRcvRdeFltUz7fef4Y= Received: by simark.ca (Postfix, from userid 112) id C377D1E067; Tue, 05 May 2026 13:14:08 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=PoZqZJNR; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0D8301E067 for ; Tue, 05 May 2026 13:14:08 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 826BE4BABF30 for ; Tue, 5 May 2026 17:14:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 826BE4BABF30 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=PoZqZJNR Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id D42DE4BA2E27 for ; Tue, 5 May 2026 17:13:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D42DE4BA2E27 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D42DE4BA2E27 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778001214; cv=none; b=BXHw27gfEmU8mAsnn48UKzBTRkZWBStgATAKvvPvPJPwgYZQ/DeO9avmOV/Nm3EtjsVfsePO615FPQIi37q8w2BxqHyozy4cGGnJ0IhA9uzZUQdYDRkmSBeb1NyAZm75LiYiTV/a2JD0wNgohchuYJeuq0wLKf9sBTqucgZeAsA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778001214; c=relaxed/simple; bh=DQjGSpNKjKVVgJeXAd0PoVsQhFVBfGnjKRP0vDYOgXA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=ilEByda/oMLElzvQl2Ppmg9OW+0UTKh5dBcsSxRU5TL/LmUeUOijd9QK+f4QFLTXjVBbXq8LGORI2lX5Wu371cQo50owpCggfSoWZTO+F1ZI6e0MaJDCN1zVSKj8u7fsOQTboTYAdlqk2j1oDmO+QfHw9DUwstBYUS57Mzs4e7U= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D42DE4BA2E27 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1778001208; bh=DQjGSpNKjKVVgJeXAd0PoVsQhFVBfGnjKRP0vDYOgXA=; h=Date:Subject:To:References:From:In-Reply-To:From; b=PoZqZJNR7xoa99iAtQt+xXxpOw6rG/Yj+MJTOW2C8kGY7FemJXNJnVGij68JYhn1R H1uqYlP4qb1mDQ2LDU9wQSgdiPaED+XKIU4SUCqr5FXjFrHfPL/d/NA1WH6+BlB9mJ zkhQDx0OrNwbq1C1j+quGvsw7BXOAmY+WbZjvjQo= Received: by simark.ca (Postfix) id 638461E067; Tue, 05 May 2026 13:13:28 -0400 (EDT) Message-ID: <6c186838-6046-4781-b90b-dac816279879@simark.ca> Date: Tue, 5 May 2026 13:13:28 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Return iteration_status from iterate_over_objfiles_in_search_order_cb_ftype To: Tom Tromey , gdb-patches@sourceware.org References: <20260505150228.474870-1-tromey@adacore.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <20260505150228.474870-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > @@ -631,26 +631,26 @@ gdbpy_lookup_objfile (PyObject *self, PyObject *args, PyObject *kw) > { > /* Don't return separate debug files. */ > if (obj->separate_debug_objfile_backlink != nullptr) > - return false; > + return iteration_status::keep_going; > > if ((obj->flags & OBJF_NOT_FILENAME) != 0) > - return false; > + return iteration_status::keep_going; > > const char *filename = objfile_filename (obj); > if (filename != NULL > && compare_filenames_for_search (filename, name)) > { > objfile = obj; > - return true; > + return iteration_status::keep_going; > } > > if (compare_filenames_for_search (obj->original_name, name)) > { > objfile = obj; > - return true; > + return iteration_status::keep_going; > } These last two look wrong. Other than that, LGTM. Approved-By: Simon Marchi Simon