From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Add test for load command
Date: Mon, 26 Feb 2018 20:59:00 -0000 [thread overview]
Message-ID: <6bc636898beba59b5e312debb9079817@polymtl.ca> (raw)
In-Reply-To: <87lgffpnon.fsf@tromey.com>
On 2018-02-26 14:15, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
>
> Simon> [[Hi Tom,
> Simon> What do you think of adding this test to check this code
> path?]]
>
> Simon> There doesn't seem to by any test for the load command. I
> suggest to
> Simon> add this test, so that we can have a minimum of confidence we
> don't
> Simon> break it completely while refactoring the code that implements
> it.
>
> This seems like a good idea to me. I read the test and it seems
> reasonable.
>
> Thank you very much for doing this.
>
> Tom
Thanks. I did a buildbot run to make sure I did not break other tests
with the gdb.exp changes. It looked good so I pushed it. The new test
doesn't cover everything (e.g. writing to flash), but it's better than
nothing.
Simon
next prev parent reply other threads:[~2018-02-26 20:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-25 17:37 [RFA] Change target_write_memory_blocks to use std::vector Tom Tromey
2018-02-25 20:44 ` [PATCH] Add test for load command Simon Marchi
2018-02-26 19:16 ` Tom Tromey
2018-02-26 20:59 ` Simon Marchi [this message]
2018-02-25 22:26 ` [RFA] Change target_write_memory_blocks to use std::vector Simon Marchi
2018-02-26 19:38 ` Tom Tromey
2018-02-26 19:45 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bc636898beba59b5e312debb9079817@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox