From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3694 invoked by alias); 26 Feb 2018 20:59:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3244 invoked by uid 89); 26 Feb 2018 20:59:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Feb 2018 20:59:37 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w1QKxUdB001054 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 26 Feb 2018 15:59:35 -0500 Received: by simark.ca (Postfix, from userid 112) id 557011F427; Mon, 26 Feb 2018 15:59:30 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id A5EE01E072; Mon, 26 Feb 2018 15:59:29 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 26 Feb 2018 20:59:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Add test for load command In-Reply-To: <87lgffpnon.fsf@tromey.com> References: <20180225173703.6675-1-tom@tromey.com> <20180225204354.6307-1-simon.marchi@polymtl.ca> <87lgffpnon.fsf@tromey.com> Message-ID: <6bc636898beba59b5e312debb9079817@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.4 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 26 Feb 2018 20:59:30 +0000 X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00405.txt.bz2 On 2018-02-26 14:15, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> [[Hi Tom, > Simon> What do you think of adding this test to check this code > path?]] > > Simon> There doesn't seem to by any test for the load command. I > suggest to > Simon> add this test, so that we can have a minimum of confidence we > don't > Simon> break it completely while refactoring the code that implements > it. > > This seems like a good idea to me. I read the test and it seems > reasonable. > > Thank you very much for doing this. > > Tom Thanks. I did a buildbot run to make sure I did not break other tests with the gdb.exp changes. It looked good so I pushed it. The new test doesn't cover everything (e.g. writing to flash), but it's better than nothing. Simon