From: Keith Seitz <keiths@redhat.com>
To: Stephan Rohr <stephan.rohr@intel.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 1/1] gdb: fix path expression for anonymous union members
Date: Fri, 9 Oct 2026 10:59:35 -0700 [thread overview]
Message-ID: <6b33ffce-29bf-465c-b0d9-71eb7b287297@redhat.com> (raw)
In-Reply-To: <20261009132139.37218-2-stephan.rohr@intel.com>
On 10/9/26 6:21 AM, Stephan Rohr wrote:
>
> Extract the required logic from cplus_describe_child and use it to get
> the correct index of the field within the parent type. With this change
> the path expression is computed correctly:
>
> interpret mi "-var-info-path-expression var1.public.1_anonymous.public.c"
> ^done,path_expr="((s).c)"
>
> I extended the related test to cover base classes and access-level
> layers. To compute the expected path expressions, the test library
> treats a child as a base class if its type equals its name and its
> parent is not an artificial public/private/protected varobj.
This LGTM. Thank you!
Reviewed-By: Keith Seitz <keiths@redhat.com>
Keith
next prev parent reply other threads:[~2026-10-09 18:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 13:21 [PATCH v2 0/1] " Stephan Rohr
2026-10-09 13:21 ` [PATCH v2 1/1] " Stephan Rohr
2026-10-09 17:59 ` Keith Seitz [this message]
2026-10-14 16:31 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b33ffce-29bf-465c-b0d9-71eb7b287297@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=stephan.rohr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox