From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id bjmHBK8ryWpYRSEAWB0awg (envelope-from ) for ; Fri, 09 Oct 2026 14:00:15 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=GVEAbe1Z; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E3D251E051; Fri, 09 Oct 2026 14:00:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1854A1E04E for ; Fri, 09 Oct 2026 14:00:14 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8B7B84BA2E11 for ; Fri, 9 Oct 2026 18:00:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8B7B84BA2E11 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=GVEAbe1Z Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 099084BA5435 for ; Fri, 9 Oct 2026 17:59:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 099084BA5435 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 099084BA5435 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791568783; cv=none; b=dWqcog4GxgRIIG8nM5ilxI2fpQ2mr5bRI2n6pJr5k1vXTHLGsvg1IfbwwhG9QQ/ec9iRulAN+wP09qL5DBxWmFBuc1391X8mSfEfPgXRH9tlfSnVvAglRJFWAP9AJw+NjvRUhd0iswVY+h4I8wL1pHg5nZsKOeHCzGETfyw0Bao= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791568783; c=relaxed/simple; bh=ypMbFqEXR1VpApWXV2ah6e7RSwzcTaF9adhfTszKe0k=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=coVEjqeO9IESoYC1lh/W3VLUiFwInXIJhBHnCQvQztnCVmfJBV/hXMJvAXPd5SZupp8pjVTlBpzOXRCtqj+p63IMwe9yuG51BxKpUJ9nVwr+tYRkApnECZySBWm1dFKm6a3+qqFYDMjgTqYMmchFGNFFLGAEPbYy6DK/OKSaL74= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=GVEAbe1Z DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 099084BA5435 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1791568782; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xFXowwmuoc6K9QZx9xS43ACHbY0WOQ+Z6tMZ3NFtILs=; b=GVEAbe1ZtoP5bsoK7XCrecoW4YcGtTF7HFlatV4sFTLFDIh3CkwLK98LjW//qah5z1DPp3 aheZO0175ac/ZdllQc6/66mRQWGDp93uxhd+RYqV/bAIsCoj5kI/FzHTyXuW3eQRhl7Azv R93zaRB2sXlHHO7gJbnGAdL4pKGNypI= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-7HD7Tw3EMs-iGBh6NJnDEg-1; Fri, 9 Oct 2026 17:59:40 +0000 X-MC-Unique: 7HD7Tw3EMs-iGBh6NJnDEg-1 X-Mimecast-MFC-AGG-ID: 7HD7Tw3EMs-iGBh6NJnDEg_1791568779 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-38e8fee6af3so7708671a91.1 for ; Fri, 09 Oct 2026 10:59:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791568779; x=1792173579; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xFXowwmuoc6K9QZx9xS43ACHbY0WOQ+Z6tMZ3NFtILs=; b=a+zVIA3ELpMfCbENVnqSqB3WXPUElNbSJ4nh2qQgdEjqEgyazQEDKIt/Q0wHoyZA/b HxL++wQK3P3+LfQS+odb0pheLGt6HmIuowt2xre355uKpBttLk1VP3fgmnVht6yr3aRg vtSd1uL6KTqouBFp7wPZwZpN9G5VmGVBd7G11LtocGBAiiygmy1h8XHUJKtvbCVa0t1U /FfaKn3Hz8Jzlvc21LsrwHyxW4w7I9xr8L1Q3cKhVDspwumOH9hybCJ4/YujkRUvrCwJ 8TEb9ikn3QKMTtuJ8bg/U3U4Z1VNyllu7irttizR6hv1cvtiGfWArD2thhpk+L2XFBOG zhgg== X-Forwarded-Encrypted: i=1; AKwUvBzMRMPJOqjtX7vp4Ds/VG95gG6lC831mfqhRBOkN2SjYPqyz2mfA0xkoaS+yVkWdU7XsyISMxH717h0Cw==@sourceware.org X-Gm-Message-State: AFq9FYJDEzalvZHJTVnY6njim7ExeIGNDCAT3X+19lXkcS/RwBWhXQXd soifQ9sLS2UtQ9Ro84ll2Lz4W0cKAkCuCjFoERoFBf3CcvJxwiDnV8Wp2k3Kmj5Fst7YsTkJZec 9bVhAofsxso6cTd6KjSCpj/LiLUBjBGvSgyHzZCpzVmwWLl8ZWZ4ZJW31Em9YWl8= X-Gm-Gg: AYBFou3KxFmWOjieVo+ipXh8vwpqVGjwQ+hlWKbZOVIeCAWgR0Gb2O4DY1RMz2EUjMT 4qTdzb3BtqyOUsthQRRsbs+1I257R+FqF05u+MawCvlDvxMJ1kmQOYlD0lZDoun9RDKOXmtqmfW rvkJ8i7um1ftnJahV4Tc7JMGpkgWCzikKscti3vvlyf23VUNY5TJ5sxyIrnueV1mDi4+RI2E/dG +NxQoI+6A5ygalhUKUkdkzNx7l+WkiAlusew8/RuGR0V0QN7/g4R3EaTo42cTx1hQqa5jIdXHWP fvfCJZ80DB494v95aCjuhUO8BylRiqDgycuycmTJiLRgLcH/Y4agMXluwTyVpjq6FNsrMGfz2Hz LUZP13A== X-Received: by 2002:a17:90b:52:b0:3aa:f2c4:12e7 with SMTP id 98e67ed59e1d1-3ab3a7474dfmr2420675a91.20.1791568779115; Fri, 09 Oct 2026 10:59:39 -0700 (PDT) X-Received: by 2002:a17:90b:52:b0:3aa:f2c4:12e7 with SMTP id 98e67ed59e1d1-3ab3a7474dfmr2420661a91.20.1791568778555; Fri, 09 Oct 2026 10:59:38 -0700 (PDT) Received: from [150.1.200.157] ([172.56.105.42]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ab36ed0daesm4555526a91.5.2026.10.09.10.59.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Oct 2026 10:59:38 -0700 (PDT) Message-ID: <6b33ffce-29bf-465c-b0d9-71eb7b287297@redhat.com> Date: Fri, 9 Oct 2026 10:59:35 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/1] gdb: fix path expression for anonymous union members To: Stephan Rohr , gdb-patches@sourceware.org References: <20261009132139.37218-1-stephan.rohr@intel.com> <20261009132139.37218-2-stephan.rohr@intel.com> From: Keith Seitz In-Reply-To: <20261009132139.37218-2-stephan.rohr@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: XT502X6_irkkFtI173mucWVKjMnqDQ2Ic_TNLpPOZK0_1791568779 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 10/9/26 6:21 AM, Stephan Rohr wrote: > > Extract the required logic from cplus_describe_child and use it to get > the correct index of the field within the parent type. With this change > the path expression is computed correctly: > > interpret mi "-var-info-path-expression var1.public.1_anonymous.public.c" > ^done,path_expr="((s).c)" > > I extended the related test to cover base classes and access-level > layers. To compute the expected path expressions, the test library > treats a child as a base class if its type equals its name and its > parent is not an artificial public/private/protected varobj. This LGTM. Thank you! Reviewed-By: Keith Seitz Keith