Re: [PATCH] [gdb/config/djgpp] Make djcheck.sh and djconfig.sh shellcheck-clean

[Tom de Vries <tdevries@suse.de>]

On 8/31/26 1:47 PM, Eli Zaretskii wrote:
>> From: Tom de Vries <tdevries@suse.de>
>> Date: Mon, 31 Aug 2026 12:08:26 +0200
>>
>> Make gdb/config/djgpp/{djcheck.sh,djconfig.sh} shellcheck-clean:
>> - add missing quotes
>> - add "|| exit 1" after cd
>> - use printf instead of echo -n
>> - use $()
>> - disable SC2016 for "configure --prefix='${DJDIR}' assuming ${DJDIR} is
>>    indeed not meant to be expanded
> 
> What's the problem with `foo` that you replace it with $() everywhere?
> 

Here ( https://www.shellcheck.net/wiki/SC2006 ) it's mentioned:
...
Rationale

Backtick command substitution `...` is legacy syntax with several issues.

     It has a series of undefined behaviors related to quoting in POSIX.
     It imposes a custom escaping mode with surprising results.
     It's exceptionally hard to nest.

$(...) command substitution has none of these problems, and is therefore 
strongly encouraged.
...

> I don't remember, but there's a risk that DJGPP ports of Bash might
> not support the latter.

I suppose I can suppress this rule in the entire directory using a 
.shellcheckrc entry.

Thanks,
- Tom