From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id HdIaGLlrlWq/RhcAWB0awg (envelope-from ) for ; Mon, 31 Aug 2026 07:55:37 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=WKo8Dm5p; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=zUW6CyAO; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Q19M0G0M; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=aLoOSSt+; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4D2961E033; Mon, 31 Aug 2026 07:55:37 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 846151E033 for ; Mon, 31 Aug 2026 07:55:36 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 961A94BA23FE for ; Mon, 31 Aug 2026 11:55:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 961A94BA23FE Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=WKo8Dm5p; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=zUW6CyAO; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Q19M0G0M; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=aLoOSSt+ Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 2F5634BA2E22 for ; Mon, 31 Aug 2026 11:55:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2F5634BA2E22 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2F5634BA2E22 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788177306; cv=none; b=peiUucYjeHb9i+IywthefGgay/SGEBDygdbtfOuF6bE47Mr5WP1fXEgGiAduJlKUbEFiRtHHquuBeWiP3LwLwi8hd3AwyhzpTBZ1Ydb9Ywwk9sPth5RoR8pi8cvWqLyGq2ufwncpRIH51dcXBe+QN7AtWqkYTs4az/5t7Cvapf0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788177306; c=relaxed/simple; bh=N+bMDV9JRTwb8EcGG/OvFhRc2JKevUg9urXxdcrXfI0=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=DOmBbg3I+1Y9r3EhQrl0iR31FtR0nAscbe6AoxX8r7WnKh0khwURd0PWGz/QRwW0XjulfmklipZ6W84A9KNG+ULPMAp38nBqhfQ88FwrwZ1udpJ2mKTLZrSIITvtCfxrp/a1qhlfM2myOXUQ4ffHHhX942Rpe3i3uUU3r3S0fgM= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=WKo8Dm5p; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=zUW6CyAO; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Q19M0G0M; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=aLoOSSt+ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2F5634BA2E22 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0621E21C4B; Mon, 31 Aug 2026 11:54:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788177301; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HhU0n4PgBsjamtoaMUVcrMTkbJF30n7Zetxqlz3wAV0=; b=WKo8Dm5p38JKDNHWS5rnrWN1hjtdESnmE+THj5lgMh18jS2bFU4ZLShgHKV/tW+O12Z5zJ ILLsupXk0kO+MZtEX86tnkvIBNcM641klyyThV0EvAft6/D/j2P6en/22GTG6JDcklLdiC J93oEeSFzRDPeGqhSbO275Q+0Rn457U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788177301; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HhU0n4PgBsjamtoaMUVcrMTkbJF30n7Zetxqlz3wAV0=; b=zUW6CyAOqU7VwGkIqtDf+vnpgQITiutVnGkjCZOXmV2QKVJtrSt20Nc1NNcB27ox/mfrYu ePEcehO4tZDUTRAg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Q19M0G0M; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=aLoOSSt+ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788177297; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HhU0n4PgBsjamtoaMUVcrMTkbJF30n7Zetxqlz3wAV0=; b=Q19M0G0MNe3m4921asMqHgH5fUAE0umU8ykq289SQHVvgq3ja5sLDN/niwpeYrFrgUEMLd 4sdWQarJ1N6O0SkK8Jb49/+RQl4SdQWJ6+HVPmF7MM4jrQXU+VVojmv/jYFQDEU6hjtaw5 Ah52DDz4R52et7w2xCBiyHFULGKdQdo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788177297; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HhU0n4PgBsjamtoaMUVcrMTkbJF30n7Zetxqlz3wAV0=; b=aLoOSSt+eE6UhdCW3hOkGS9CCzse3gl8poDyHpyU6Hi0ID6xf2V2i96hkYSwkfuYwb+qDB NLle1JcfgZdoHYCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C805813515; Mon, 31 Aug 2026 11:54:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id UrSBL5BrlWoLZAAAD6G6ig (envelope-from ); Mon, 31 Aug 2026 11:54:56 +0000 Message-ID: <6a252b3f-d0c3-4744-97ea-af18822674b1@suse.de> Date: Mon, 31 Aug 2026 13:54:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/config/djgpp] Make djcheck.sh and djconfig.sh shellcheck-clean To: Eli Zaretskii Cc: gdb-patches@sourceware.org, DJ Delorie References: <20260831100826.3521717-1-tdevries@suse.de> <86pkyy8qbn.fsf@gnu.org> Content-Language: en-US From: Tom de Vries In-Reply-To: <86pkyy8qbn.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 0621E21C4B X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email,suse.de:mid,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/31/26 1:47 PM, Eli Zaretskii wrote: >> From: Tom de Vries >> Date: Mon, 31 Aug 2026 12:08:26 +0200 >> >> Make gdb/config/djgpp/{djcheck.sh,djconfig.sh} shellcheck-clean: >> - add missing quotes >> - add "|| exit 1" after cd >> - use printf instead of echo -n >> - use $() >> - disable SC2016 for "configure --prefix='${DJDIR}' assuming ${DJDIR} is >> indeed not meant to be expanded > > What's the problem with `foo` that you replace it with $() everywhere? > Here ( https://www.shellcheck.net/wiki/SC2006 ) it's mentioned: ... Rationale Backtick command substitution `...` is legacy syntax with several issues. It has a series of undefined behaviors related to quoting in POSIX. It imposes a custom escaping mode with surprising results. It's exceptionally hard to nest. $(...) command substitution has none of these problems, and is therefore strongly encouraged. ... > I don't remember, but there's a risk that DJGPP ports of Bash might > not support the latter. I suppose I can suppress this rule in the entire directory using a .shellcheckrc entry. Thanks, - Tom