Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Marc Khouzam" <marc.khouzam@ericsson.com>
To: "Hui Zhu" <teawater@gmail.com>, "Michael Snyder" <msnyder@vmware.com>
Cc: "gdb-patches ml" <gdb-patches@sourceware.org>
Subject: RE: [PRecord] Memory gets set even if users responds 'n' to query
Date: Tue, 21 Jul 2009 08:23:00 -0000	[thread overview]
Message-ID: <6D19CA8D71C89C43A057926FE0D4ADAA07C00028@ecamlmw720.eamcs.ericsson.se> (raw)
In-Reply-To: <daef60380907202018s4a15735ei3bd19a2083843590@mail.gmail.com>

> -----Original Message-----
> From: Hui Zhu [mailto:teawater@gmail.com] 
> Sent: July-20-09 11:19 PM
> To: Marc Khouzam; Michael Snyder
> Cc: gdb-patches ml
> Subject: Re: [PRecord] Memory gets set even if users responds 
> 'n' to query
> 
> Thanks Marc.
> 
> This issue is because when user answer n, function record_xfer_partial
> return -1 will not really cancel the memory change operation.
> I make a patch to change it to error.
> 
> And I have check the code about register, it works OK.  Because it
> already use error.
> 
> Please help me review it.

Thanks Hui, I have tested your fix and it works for me.

marc


  reply	other threads:[~2009-07-21  3:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <6D19CA8D71C89C43A057926FE0D4ADAA07C00000@ecamlmw720.eamcs.ericsson.se>
2009-07-21  3:38 ` Hui Zhu
2009-07-21  8:23   ` Marc Khouzam [this message]
2009-07-22  8:55     ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6D19CA8D71C89C43A057926FE0D4ADAA07C00028@ecamlmw720.eamcs.ericsson.se \
    --to=marc.khouzam@ericsson.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox