From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-65527-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 25308 invoked by alias); 21 Jul 2009 03:38:33 -0000
Received: (qmail 25300 invoked by uid 22791); 21 Jul 2009 03:38:32 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 	tests=AWL,BAYES_00,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from imr1.ericy.com (HELO imr1.ericy.com) (198.24.6.9)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 21 Jul 2009 03:38:21 +0000
Received: from eusrcmw751.eamcs.ericsson.se (eusrcmw751.exu.ericsson.se [138.85.77.51]) 	by imr1.ericy.com (8.13.1/8.13.1) with ESMTP id n6L3cHFa032197; 	Mon, 20 Jul 2009 22:38:18 -0500
Received: from ecamlmw720.eamcs.ericsson.se ([142.133.1.72]) by eusrcmw751.eamcs.ericsson.se with Microsoft SMTPSVC(6.0.3790.3959); 	 Mon, 20 Jul 2009 22:38:13 -0500
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain; 	charset="US-ASCII"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PRecord] Memory gets set even if users responds 'n' to query
Date: Tue, 21 Jul 2009 08:23:00 -0000
Message-ID: <6D19CA8D71C89C43A057926FE0D4ADAA07C00028@ecamlmw720.eamcs.ericsson.se>
In-Reply-To: <daef60380907202018s4a15735ei3bd19a2083843590@mail.gmail.com>
References: <6D19CA8D71C89C43A057926FE0D4ADAA07C00000@ecamlmw720.eamcs.ericsson.se> <daef60380907202018s4a15735ei3bd19a2083843590@mail.gmail.com>
From: "Marc Khouzam" <marc.khouzam@ericsson.com>
To: "Hui Zhu" <teawater@gmail.com>, "Michael Snyder" <msnyder@vmware.com>
Cc: "gdb-patches ml" <gdb-patches@sourceware.org>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-07/txt/msg00506.txt.bz2

> -----Original Message-----
> From: Hui Zhu [mailto:teawater@gmail.com]=20
> Sent: July-20-09 11:19 PM
> To: Marc Khouzam; Michael Snyder
> Cc: gdb-patches ml
> Subject: Re: [PRecord] Memory gets set even if users responds=20
> 'n' to query
>=20
> Thanks Marc.
>=20
> This issue is because when user answer n, function record_xfer_partial
> return -1 will not really cancel the memory change operation.
> I make a patch to change it to error.
>=20
> And I have check the code about register, it works OK.  Because it
> already use error.
>=20
> Please help me review it.

Thanks Hui, I have tested your fix and it works for me.

marc