From: "Marc Khouzam" <marc.khouzam@ericsson.com>
To: <gdb-patches@sourceware.org>
Subject: [MI][Patch] -exec-continue/interrupt --thread-group expects wrong id
Date: Fri, 05 Jun 2009 17:34:00 -0000 [thread overview]
Message-ID: <6D19CA8D71C89C43A057926FE0D4ADAA0789E1B2@ecamlmw720.eamcs.ericsson.se> (raw)
Hi,
After Pedro kindly pointed out that there is a
--thread-group parameter to -exec-continue and -exec-interrupt
(how did I miss that?) I tried them out.
I found that they still expect the old form of the
threadGroupId (starting with a 'p').
The patch below fixes both methods.
This is hard to test since HEAD does not have a fully functional
multi-process, but I was able to confirm that the threadGroupId
gets properly accepted with my patch.
Thanks
marc
--- gdb/mi/mi-main.c 8 Apr 2009 06:58:37 -0000 1.147
+++ gdb/mi/mi-main.c 5 Jun 2009 17:15:42 -0000
@@ -205,7 +205,7 @@
int pid;
if (argv[1] == NULL || argv[1] == '\0')
error ("Thread group id not specified");
- pid = atoi (argv[1] + 1);
+ pid = atoi (argv[1]);
if (!in_inferior_list (pid))
error ("Invalid thread group id '%s'", argv[1]);
@@ -260,7 +260,7 @@
int pid;
if (argv[1] == NULL || argv[1] == '\0')
error ("Thread group id not specified");
- pid = atoi (argv[1] + 1);
+ pid = atoi (argv[1]);
if (!in_inferior_list (pid))
error ("Invalid thread group id '%s'", argv[1]);
next reply other threads:[~2009-06-05 17:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 17:34 Marc Khouzam [this message]
2009-06-05 18:36 ` Vladimir Prus
2009-06-05 18:42 ` Marc Khouzam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6D19CA8D71C89C43A057926FE0D4ADAA0789E1B2@ecamlmw720.eamcs.ericsson.se \
--to=marc.khouzam@ericsson.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox