From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24601 invoked by alias); 5 Jun 2009 17:34:11 -0000 Received: (qmail 24593 invoked by uid 22791); 5 Jun 2009 17:34:10 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_05,SPF_PASS X-Spam-Check-By: sourceware.org Received: from imr2.ericy.com (HELO imr2.ericy.com) (198.24.6.3) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 05 Jun 2009 17:34:04 +0000 Received: from eusrcmw751.eamcs.ericsson.se (eusrcmw751.exu.ericsson.se [138.85.77.51]) by imr2.ericy.com (8.13.1/8.13.1) with ESMTP id n55HXxRl026285 for ; Fri, 5 Jun 2009 12:34:00 -0500 Received: from ecamlmw720.eamcs.ericsson.se ([142.133.1.72]) by eusrcmw751.eamcs.ericsson.se with Microsoft SMTPSVC(6.0.3790.1830); Fri, 5 Jun 2009 12:33:59 -0500 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: quoted-printable Subject: [MI][Patch] -exec-continue/interrupt --thread-group expects wrong id Date: Fri, 05 Jun 2009 17:34:00 -0000 Message-ID: <6D19CA8D71C89C43A057926FE0D4ADAA0789E1B2@ecamlmw720.eamcs.ericsson.se> From: "Marc Khouzam" To: X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00103.txt.bz2 Hi, After Pedro kindly pointed out that there is a --thread-group parameter to -exec-continue and -exec-interrupt (how did I miss that?) I tried them out. I found that they still expect the old form of the=20 threadGroupId (starting with a 'p'). The patch below fixes both methods. This is hard to test since HEAD does not have a fully functional multi-process, but I was able to confirm that the threadGroupId gets properly accepted with my patch. Thanks marc --- gdb/mi/mi-main.c 8 Apr 2009 06:58:37 -0000 1.147 +++ gdb/mi/mi-main.c 5 Jun 2009 17:15:42 -0000 @@ -205,7 +205,7 @@ int pid; if (argv[1] =3D=3D NULL || argv[1] =3D=3D '\0') error ("Thread group id not specified"); - pid =3D atoi (argv[1] + 1); + pid =3D atoi (argv[1]); if (!in_inferior_list (pid)) error ("Invalid thread group id '%s'", argv[1]); =20 @@ -260,7 +260,7 @@ int pid; if (argv[1] =3D=3D NULL || argv[1] =3D=3D '\0') error ("Thread group id not specified"); - pid =3D atoi (argv[1] + 1); + pid =3D atoi (argv[1]); if (!in_inferior_list (pid)) error ("Invalid thread group id '%s'", argv[1]);