From: Pedro Alves <palves@redhat.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCHv2] gdb/x86: Handle kernels using compact xsave format
Date: Fri, 04 May 2018 19:23:00 -0000 [thread overview]
Message-ID: <69fb8b2c-0450-7727-4ba1-fee38b3f24f1@redhat.com> (raw)
In-Reply-To: <20180504191441.GL3375@embecosm.com>
On 05/04/2018 08:14 PM, Andrew Burgess wrote:
> * Pedro Alves <palves@redhat.com> [2018-05-04 11:39:42 +0100]:
>
>> On 05/03/2018 06:37 PM, Andrew Burgess wrote:
>>
>>> Hope that helps,
>>
>> It does, thank you.
>>
>> The patch looks good to me, with the following nits
>> addressed.
>
> Thanks for all the review feedback.
>
> I've attached the new version below, the only changes are those you
> suggested in your review, so I think the patch is now approved. Still
> I wanted to give you a chance to take a final look. If I don't hear
> anything in a few days I'll apply this version.
LGTM.
Thanks,
Pedro Alves
prev parent reply other threads:[~2018-05-04 19:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 17:06 Andrew Burgess
2018-05-03 17:11 ` Pedro Alves
2018-05-03 17:37 ` Andrew Burgess
2018-05-04 10:39 ` Pedro Alves
2018-05-04 19:14 ` Andrew Burgess
2018-05-04 19:23 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69fb8b2c-0450-7727-4ba1-fee38b3f24f1@redhat.com \
--to=palves@redhat.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox