From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120293 invoked by alias); 4 May 2018 19:23:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120281 invoked by uid 89); 4 May 2018 19:23:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hope, hear X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 04 May 2018 19:23:26 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 06DB7A202E; Fri, 4 May 2018 19:23:25 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 15D4C2166BAD; Fri, 4 May 2018 19:23:23 +0000 (UTC) Subject: Re: [PATCHv2] gdb/x86: Handle kernels using compact xsave format To: Andrew Burgess References: <20180503170624.20847-1-andrew.burgess@embecosm.com> <6131c1b9-21c1-6a38-f466-34bfef144a26@redhat.com> <20180503173712.GI3375@embecosm.com> <3c303c56-2315-fb00-dff1-805ec84a115c@redhat.com> <20180504191441.GL3375@embecosm.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <69fb8b2c-0450-7727-4ba1-fee38b3f24f1@redhat.com> Date: Fri, 04 May 2018 19:23:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180504191441.GL3375@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-05/txt/msg00143.txt.bz2 On 05/04/2018 08:14 PM, Andrew Burgess wrote: > * Pedro Alves [2018-05-04 11:39:42 +0100]: > >> On 05/03/2018 06:37 PM, Andrew Burgess wrote: >> >>> Hope that helps, >> >> It does, thank you. >> >> The patch looks good to me, with the following nits >> addressed. > > Thanks for all the review feedback. > > I've attached the new version below, the only changes are those you > suggested in your review, so I think the patch is now approved. Still > I wanted to give you a chance to take a final look. If I don't hear > anything in a few days I'll apply this version. LGTM. Thanks, Pedro Alves