From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: remove local extern declaration of cli_styling
Date: Wed, 18 Sep 2019 17:36:00 -0000 [thread overview]
Message-ID: <692d79ed-ef00-4f5b-3c76-7780f81ab52a@polymtl.ca> (raw)
In-Reply-To: <87muf1tw64.fsf@tromey.com>
On 2019-09-18 12:18 p.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
>
> Simon> * ui-file.c: Include cli/cli-style.h.
> Simon> (term_cli_styling): Remove cli_styling declaration.
>
> Thanks for doing this.
>
> I think as a rule it's best to always have declarations in a header and
> never in the .c code. That way they can be checked against the
> definition.
Yes, agreed.
Actually, I didn't push this patch directly, even though it seemed obvious, because
I was wondering if there was some good reason I was missing for not doing it like
this in the first place.
I pushed it now.
Simon
prev parent reply other threads:[~2019-09-18 17:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 3:05 Simon Marchi
2019-09-18 16:18 ` Tom Tromey
2019-09-18 17:36 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=692d79ed-ef00-4f5b-3c76-7780f81ab52a@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox