From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6836 invoked by alias); 18 Sep 2019 17:36:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6828 invoked by uid 89); 18 Sep 2019 17:36:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Sep 2019 17:36:20 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x8IHaDtL007156 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 18 Sep 2019 13:36:18 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca x8IHaDtL007156 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1568828178; bh=iBuYHGI6VGU9wcGCFKsMP8ftoMkyBgOCAVEQcr9bM0M=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=iGAE0RIjg4N9okSk83H36gP8dY5xWvDgEXcBVj6wnxU7sZ4gv7zglAXg9KZg+KO2h ibYulMUM+cLoPWBTfRwZfxj0HMKZ//38XWaaSJV5DUvMhgvqnX1jz4XpNu0EpzG3Nv 6ZpI+rQjnrKrqZCnpi75TWwO5m484Hq/NBE3RTMQ= Received: from [172.16.0.120] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 228691E093; Wed, 18 Sep 2019 13:36:13 -0400 (EDT) Subject: Re: [PATCH] gdb: remove local extern declaration of cli_styling To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20190918030533.365417-1-simon.marchi@polymtl.ca> <87muf1tw64.fsf@tromey.com> From: Simon Marchi Message-ID: <692d79ed-ef00-4f5b-3c76-7780f81ab52a@polymtl.ca> Date: Wed, 18 Sep 2019 17:36:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <87muf1tw64.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00346.txt.bz2 On 2019-09-18 12:18 p.m., Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> * ui-file.c: Include cli/cli-style.h. > Simon> (term_cli_styling): Remove cli_styling declaration. > > Thanks for doing this. > > I think as a rule it's best to always have declarations in a header and > never in the .c code. That way they can be checked against the > definition. Yes, agreed. Actually, I didn't push this patch directly, even though it seemed obvious, because I was wondering if there was some good reason I was missing for not doing it like this in the first place. I pushed it now. Simon