From: Guinevere Larsen <blarsen@redhat.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: Fix printing frame when reversing out of a recursive call with clang
Date: Mon, 19 Aug 2024 09:12:52 -0300 [thread overview]
Message-ID: <67598d73-efbe-41e8-a77b-648d88dc43c0@redhat.com> (raw)
In-Reply-To: <20240818113852.50bf6167@f40-zbm-amd>
On 8/18/24 3:38 PM, Kevin Buettner wrote:
> On Wed, 14 Aug 2024 13:50:36 -0300
> Guinevere Larsen <blarsen@redhat.com> wrote:
>
>> Commit bf2813aff8f2988ad3d53e819a0415abf295c91f introduced some logic to
>> not refresh the step frame id if it detects that the inferior is reverse
>> stepping out of a recursive call, so that we would still print frame
>> information once the inferior stops.
>>
>> However, that logic was overly specific, and wouldn't be hit for
>> inferiors compiled with clang because clang adds line table entries that
>> aren't statements, making process_event_stop_test go through a different
>> branch on the relevant if statement.
>>
>> Fix this by not making the code that detects "reversing out of a
>> recursion" an else clause to the previous if, but a standalone if block.
> Approved-by: Kevin Buettner <kevinb@redhat.com>
>
Thanks! pushed :)
--
Cheers,
Guinevere Larsen
She/Her/Hers
prev parent reply other threads:[~2024-08-19 12:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 16:50 Guinevere Larsen
2024-08-18 18:38 ` Kevin Buettner
2024-08-19 12:12 ` Guinevere Larsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67598d73-efbe-41e8-a77b-648d88dc43c0@redhat.com \
--to=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox