From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id hOJKFec2w2ZpkwwAWB0awg (envelope-from ) for ; Mon, 19 Aug 2024 08:13:27 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=iTTG8ld4; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 44D771E0D0; Mon, 19 Aug 2024 08:13:27 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2A7BC1E0AC for ; Mon, 19 Aug 2024 08:13:25 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 159BD3865C23 for ; Mon, 19 Aug 2024 12:13:24 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 6DE343865C26 for ; Mon, 19 Aug 2024 12:13:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6DE343865C26 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6DE343865C26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724069582; cv=none; b=g7kRo8m821CcLB6t93vzEuSn2jgpKUXj+iEBEHaBnwFJbQLS3SloPPlc/fFc8Ja5RFgVh4xlfGFODmYJoQXxnBUEu8qiB0y+GVgI1Nq1icdreKw0W43zcPFyErT00fgDr0W1VEydmdLJkOh75PBtLaxTFK+nUDko+nUgGXnYIMA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724069582; c=relaxed/simple; bh=GlYc8H4kiC/l26i7ovQFFWiLtYRmz9TVHzJtutiBT3M=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=DAsYZnsvkPwu6ukKVuYqgtew4xWMVDRV5+hV6BaeipEBg/0EDBWa4u9Kw5PYPTvBQUYhrucs3nHAF5bvJJEdM3jTe4nUeo0F4azNg4wbpOE9xe05FkX1FIV39NHMNSxrdOgBWUuQmgbkl8XbGkJV0t73dCusDTEa7fESorZxhPo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724069580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JVxCZGqWXateKnkjFH4rZZkWXMRoZjdLgMKxhLxiQNM=; b=iTTG8ld4Q7gIyT9kcA1aLXIimezzdvXg0xQDKI0ngYzKrQ96NSOZinsN8AsnDQ0SUub4dY oNWU/kHAgyHGwdysEbvflipu+nws9hd2jSLqqWFUgMrDkzBmY6Ff01smEWaTDW4kP1c+in MGs10lPERDYPB4glw9bmtbKKPvQ400M= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-159-fa3xh1AFOiqi9pVzAxjZ6Q-1; Mon, 19 Aug 2024 08:12:57 -0400 X-MC-Unique: fa3xh1AFOiqi9pVzAxjZ6Q-1 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-1fd72932d74so40284965ad.1 for ; Mon, 19 Aug 2024 05:12:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724069575; x=1724674375; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JVxCZGqWXateKnkjFH4rZZkWXMRoZjdLgMKxhLxiQNM=; b=rbdbYijFWUNsCodMA3vJKIYiJro8RBwVo1xo4CBq3rfNO530hOtvim9DAi/1NrBbbD uKYWwVVUxqvwau+DltOXgYueWaqLZynQdmI1wqY5VEZ48sauNNBONmpaLzGtNRmghHR3 bbHhw2eXaQqU4TfFZD5pKbwg82Bi3WmJ/of0TQFCz4mkIDJsGYZWFKNGZO07dMnnObFT Pq8kXb6zcNy7U+z/29Q2yxFj5wzeafRVopf+CBP7iarudCTpU7iIBuQEAIRau58eGi2+ 2D+HpQDRXLYvBcbW5s/wBxjyjRgIGQdQeb0QWNElotVqUuQbH2PjK4k4aUqqmN/wGdrJ qruA== X-Gm-Message-State: AOJu0Yya2CVUM5qClGTZNX233EZObMnjQpTrAkL4UZY9lujqrUjQu9+U 1mItmMmE8PYnHhZoUPIXDvkAdm6Cer39evAnk2fAyJ8QYle/EBsoGzQwPfC6Q/IbMCWToG5LyFl 4uaaKc8V8EYO+pUSj/pslMi+1BwHaHQeAEKw4bd4qsdBa2rZ47Q2pzs0b3D1ECJ46G0U= X-Received: by 2002:a17:902:db09:b0:202:4079:1c19 with SMTP id d9443c01a7336-20240791f8fmr36167345ad.14.1724069575645; Mon, 19 Aug 2024 05:12:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFgkeDoy28VPGnrES/VSuJqhloCp4KYVcaFSjEuEqdxMmrcJv7H6kxKK+w6i94K0tsPjzP1WA== X-Received: by 2002:a17:902:db09:b0:202:4079:1c19 with SMTP id d9443c01a7336-20240791f8fmr36167115ad.14.1724069575296; Mon, 19 Aug 2024 05:12:55 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:92c5::1002? ([2804:14d:8084:92c5::1002]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-201f02faaf7sm61880365ad.10.2024.08.19.05.12.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Aug 2024 05:12:54 -0700 (PDT) Message-ID: <67598d73-efbe-41e8-a77b-648d88dc43c0@redhat.com> Date: Mon, 19 Aug 2024 09:12:52 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: Fix printing frame when reversing out of a recursive call with clang To: Kevin Buettner Cc: gdb-patches@sourceware.org References: <20240814165036.2951260-1-blarsen@redhat.com> <20240818113852.50bf6167@f40-zbm-amd> From: Guinevere Larsen In-Reply-To: <20240818113852.50bf6167@f40-zbm-amd> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/18/24 3:38 PM, Kevin Buettner wrote: > On Wed, 14 Aug 2024 13:50:36 -0300 > Guinevere Larsen wrote: > >> Commit bf2813aff8f2988ad3d53e819a0415abf295c91f introduced some logic to >> not refresh the step frame id if it detects that the inferior is reverse >> stepping out of a recursive call, so that we would still print frame >> information once the inferior stops. >> >> However, that logic was overly specific, and wouldn't be hit for >> inferiors compiled with clang because clang adds line table entries that >> aren't statements, making process_event_stop_test go through a different >> branch on the relevant if statement. >> >> Fix this by not making the code that detects "reversing out of a >> recursion" an else clause to the previous if, but a standalone if block. > Approved-by: Kevin Buettner > Thanks! pushed :) -- Cheers, Guinevere Larsen She/Her/Hers